Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement rb::Map::remove #5599

Merged
merged 24 commits into from
Sep 5, 2023
Merged

Implement rb::Map::remove #5599

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
6ab00b4
Ignore all of sandbox venv
Aug 24, 2023
ffaa0e8
Implement remove for rb::Map
Aug 24, 2023
83ff6d2
Add remove to benchmark
Aug 30, 2023
ead34d5
Revert red black color names
Aug 30, 2023
4c9bb6f
Use paint instead of blacken and redden
Aug 30, 2023
240849e
Undo changes to insert
Aug 30, 2023
773087b
Move internals to private
Aug 30, 2023
86dc997
Default rbmap to on
Aug 30, 2023
39c6e69
Fix assert color
Aug 30, 2023
6348ca9
Merge branch 'main' into rbmap-remove
jumaffre Aug 31, 2023
9cac418
Fix ifelse argument ordering
Aug 31, 2023
f2bcaf7
Add asserts for mirror case
Aug 31, 2023
6b50f5c
int -> size_t
Aug 31, 2023
c4bb661
Change print to to_str
Aug 31, 2023
b3aa4da
Revert change ifelse condition argument
Aug 31, 2023
360e8e1
Merge branch 'main' into rbmap-remove
Aug 31, 2023
6905434
Add debug guards around check and to_str
Aug 31, 2023
706fded
Update CMakeLists.txt
jumaffre Sep 1, 2023
cedc72c
Merge branch 'main' into rbmap-remove
jumaffre Sep 1, 2023
ccb7b15
Merge branch 'main' into rbmap-remove
jumaffre Sep 1, 2023
99a7fbc
Merge branch 'main' into rbmap-remove
achamayou Sep 4, 2023
84e445f
Merge branch 'main' into rbmap-remove
jumaffre Sep 5, 2023
d35a3d5
Merge branch 'main' into rbmap-remove
achamayou Sep 5, 2023
90da773
Merge branch 'main' into rbmap-remove
jumaffre Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ include/ccf/version.h
python/version.py
src/host/config_schema.h
**/compatibility_report.json
.venv_ccf_sandbox/*
.venv_ccf_sandbox/
workspace/*
ledger_[0-9]*
snapshot_[0-9]*
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ option(BUILD_END_TO_END_TESTS "Build end to end tests" ON)
option(COVERAGE "Enable coverage mapping" OFF)
option(SHUFFLE_SUITE "Shuffle end to end test suite" OFF)
option(LONG_TESTS "Enable long end-to-end tests" OFF)
option(KV_STATE_RB "Enable RBMap as underlying KV state implementation" OFF)
option(KV_STATE_RB "Enable RBMap as underlying KV state implementation" ON)
jumaffre marked this conversation as resolved.
Show resolved Hide resolved
if(KV_STATE_RB)
add_compile_definitions(KV_STATE_RB)
endif()
Expand Down
Loading