Add unwrapKey to typescript interface #5792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achamayou
reviewed
Oct 27, 2023
achamayou
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
beejones/add-unwrap-in-typescript@78304 aka 20231102.11 vs main ewma over 20 builds from 77958 to 78284 Click to see tablemain
beejones/add-unwrap-in-typescript
|
achamayou
reviewed
Oct 27, 2023
achamayou
reviewed
Oct 27, 2023
achamayou
reviewed
Oct 27, 2023
achamayou
reviewed
Oct 27, 2023
|
@beejones thank you for adding the C++ implementation. It needs testing too, a good starting point is the test for wrapKey: CCF/tests/js-modules/modules.py Line 549 in 115d1af That currently does the unwrapping in Python (which I suggest you leave in), but you could for each variant unwrap with an endpoint calling the new function and make sure the results match. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
achamayou
reviewed
Oct 31, 2023
achamayou
reviewed
Oct 31, 2023
achamayou
reviewed
Oct 31, 2023
achamayou
reviewed
Oct 31, 2023
|
@beejones thank you for adding the tests, the PR looks good. There's just one thing: the scrubbing of private keys from the heap isn't quite right and scrubs caller input rather than the temporary copies created inside the call. |
achamayou
reviewed
Nov 1, 2023
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@beejones can you merge main into your branch please? There's usually a button to do this on the PRs, I am not sure why it doesn't appear on yours. This is necessary so that the CI runs on what main would contain post-PR-merge, including all recent commits, and is automatically enforced. |
achamayou
approved these changes
Nov 2, 2023
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unwrapKey to ccfcrypto.
Make sure unit tests use the new unwrapKey function