Partially rollback public headers functions & cleanup nonstd.cpp #6362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxtropets
force-pushed
the
f/partial-rollback-nonstd-defs
branch
3 times, most recently
from
85775b0
to
5b91647
Compare
Was breaking linking against CCF from other projects (e.g. SCITT). Functions impls are required by other public CCF headers.
maxtropets
force-pushed
the
f/partial-rollback-nonstd-defs
branch
from
5b91647
to
ca7365b
Compare
maxtropets
changed the title
achamayou
reviewed
Jul 15, 2024
achamayou
reviewed
Jul 16, 2024
maxtropets
force-pushed
the
f/partial-rollback-nonstd-defs
branch
2 times, most recently
from
5f764c6
to
51bf46c
Compare
achamayou
approved these changes
Jul 16, 2024
maxtropets
force-pushed
the
f/partial-rollback-nonstd-defs
branch
from
6dac566
to
f6cae36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't link SCITT against CCF because
to_lowerandto_upperare used in other public headers (unit_strings.h, for instance).This breaks linkage of CCF against SCIIT and potentially a lot of other projects, because nobody would expect the necessity of linking to
libccf.virtual.ato make it work.Explicitly linking against it, however, also doesn't work, because it carries
INSIDE_ENCLAVEtarget properties, which also breaks SCITT build.