Remove generated 'As<I>()' methods for static types #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
force-pushed
the
user/sergiopedri/remove-static-as
branch
from
af15817
to
67350cf
Compare
|
Isn't it an ABI breaking change? I don't think it's acceptable though as all existing apps including WinRT component libraries will stop working. |
manodasanW
reviewed
May 10, 2024
| @@ -2513,43 +2511,6 @@ Marshal.Release(inner); | |||
| { | |||
| write_composable_constructors(w, factory.type, type, factory.visible ? "public"sv : "protected"sv); | |||
| } | |||
| else if (factory.statics) | |||
There was a problem hiding this comment.
We probably can't stop generating these functions due to back compat. When we generate the Windows SDK projection for instance, the backcompat check there will break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the generated
As<I>()methods on static RCW types. This method is:ActivationFactoryis public[ComImport]types, or via IDICDevs should just use
ActivationFactorydirectly, which also exposes new high perf methods.