Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Unit Test Times (Part 1) #3829

Merged
merged 9 commits into from
Jun 28, 2023
Merged

Reduce Unit Test Times (Part 1) #3829

merged 9 commits into from
Jun 28, 2023

Conversation

mrwyattii
Copy link
Contributor

@mrwyattii mrwyattii commented Jun 27, 2023

The time and resources required to run all unit tests on each PR has increased substantially in the past year. We are making an effort to reduce the tests done in order to improve the pace at which we can test and merge PRs.

Changes in this PR:

  • Move torch19* tests to nightly tests (i.e., not done for each PR)
  • Use a cached Apex build for nv-megatron. We store the build on blob storage and add it to our PYTHONPATH. In the case that Apex is updated to a new version, we will upgrade the cached build.

Changes for future PRs:

  • nv-inference
    • Utilize coverage to reduce the total number of tests to a bare minimum that touches all inference code
    • Reduce number of parameterize options
  • nv-mii
    • Add a @pytest.mark.short marker to the MII unit tests
    • Test only a subset of all MII unit tests
  • nv-torch-latest-v100
    • Use coverage to reduce total number of tests and parameterized values
  • Add email notifications to the team when nightly tests fail
  • Add a coverage report

@mrwyattii mrwyattii changed the title Reduce Unit Test Times Reduce Unit Test Times (Part 1) Jun 28, 2023
@mrwyattii mrwyattii marked this pull request as ready for review June 28, 2023 17:15
@mrwyattii mrwyattii requested a review from jeffra as a code owner June 28, 2023 17:15
@mrwyattii mrwyattii enabled auto-merge (squash) June 28, 2023 17:55
@mrwyattii mrwyattii merged commit 7726fc8 into master Jun 28, 2023
@mrwyattii mrwyattii deleted the mrwyattii/reduce-UT-time branch June 29, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants