-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logger update with torch master changes #5346
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minor fix to resolve the logger import issue caused by torch upstream cleanup. pytorch/pytorch@b6201a6 Signed-off-by: roger feng <[email protected]>
loadams
approved these changes
Apr 3, 2024
rraminen
pushed a commit
to ROCm/DeepSpeed
that referenced
this pull request
May 1, 2024
minor fix to resolve the logger import issue caused by torch upstream cleanup pytorch/pytorch@b6201a6 log variable was renamed in the torch master. To create the logger using public API to avoid compatibility issues. Fixes: microsoft#5346 --------- Signed-off-by: roger feng <[email protected]> Co-authored-by: Logan Adams <[email protected]> Co-authored-by: Logan Adams <[email protected]>
rraminen
pushed a commit
to ROCm/DeepSpeed
that referenced
this pull request
May 9, 2024
minor fix to resolve the logger import issue caused by torch upstream cleanup pytorch/pytorch@b6201a6 log variable was renamed in the torch master. To create the logger using public API to avoid compatibility issues. Fixes: microsoft#5346 --------- Signed-off-by: roger feng <[email protected]> Co-authored-by: Logan Adams <[email protected]> Co-authored-by: Logan Adams <[email protected]>
umchand
pushed a commit
to umchand/DeepSpeed
that referenced
this pull request
May 20, 2024
minor fix to resolve the logger import issue caused by torch upstream cleanup pytorch/pytorch@b6201a6 log variable was renamed in the torch master. To create the logger using public API to avoid compatibility issues. Fixes: microsoft#5346 --------- Signed-off-by: roger feng <[email protected]> Co-authored-by: Logan Adams <[email protected]> Co-authored-by: Logan Adams <[email protected]>
dbyoung18
pushed a commit
to dbyoung18/DeepSpeed
that referenced
this pull request
Jun 11, 2024
minor fix to resolve the logger import issue caused by torch upstream cleanup pytorch/pytorch@b6201a6 log variable was renamed in the torch master. To create the logger using public API to avoid compatibility issues. Fixes: microsoft#5346 --------- Signed-off-by: roger feng <[email protected]> Co-authored-by: Logan Adams <[email protected]> Co-authored-by: Logan Adams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor fix to resolve the logger import issue caused by torch upstream cleanup pytorch/pytorch@b6201a6
log variable was renamed in the torch master. To create the logger using public API to avoid compatibility issues.
Fixes: #5346