inference: remove unused _validate_args function #5505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjruwase
approved these changes
May 13, 2024
|
@nelyahu, thanks for the cleanup work. |
loadams
approved these changes
May 13, 2024
loadams
reviewed
May 13, 2024
| @@ -305,29 +304,6 @@ def _init_quantization_setting(self, quantization_setting): | |||
| f"mlp_extra_grouping = {self.mlp_extra_grouping}, " | |||
| f"quantize_groups = {self.quantize_groups}", [0]) | |||
|
|
|||
| # TODO: remove this function and add this functionality to pydantic config checking | |||
There was a problem hiding this comment.
@nelyahu - we never added this functionality/checking to the pydantic config, let me take a stab at that before we merge this PR?
|
@loadams this PR was removed from merge queue for some reason. can you check? |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
Co-authored-by: Olatunji Ruwase <[email protected]> Co-authored-by: Logan Adams <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.