Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CPU Adam JIT compilation #5780

Merged
merged 8 commits into from
Jul 31, 2024
Merged

Fix CPU Adam JIT compilation #5780

merged 8 commits into from
Jul 31, 2024

Conversation

lekurile
Copy link
Contributor

@lekurile lekurile commented Jul 18, 2024 •
edited
Loading

This PR fixes CPU Adam JIT compilation by including the CUDA_LIB64 path in the extra_ldflags list before calling load().

@loadams loadams mentioned this pull request Jul 18, 2024
Open
@lekurile
Copy link
Contributor Author

lekurile commented Jul 18, 2024 •
edited
Loading

Manual ds-chat run:
https://github.com/microsoft/DeepSpeed/actions/runs/9995112919

All tests pass.

@lekurile lekurile enabled auto-merge July 22, 2024 17:14
@loadams loadams mentioned this pull request Jul 31, 2024
Closed
@loadams loadams mentioned this pull request Jul 31, 2024
Closed
@loadams loadams disabled auto-merge July 31, 2024 21:34
@loadams loadams merged commit 681be6f into master Jul 31, 2024
10 of 11 checks passed
@loadams loadams deleted the lekurile/fix_cpu_adam_jit branch July 31, 2024 21:35
@loadams loadams mentioned this pull request Aug 1, 2024
Closed
This was referenced Aug 1, 2024
Closed
Closed
@shawnccx
Copy link

shawnccx commented Aug 8, 2024

When will the next release be cut to have this fix? @loadams

@loadams loadams mentioned this pull request Aug 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loadams loadams loadams approved these changes

@tjruwase tjruwase Awaiting requested review from tjruwase tjruwase is a code owner

@costin-eseanu costin-eseanu Awaiting requested review from costin-eseanu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lekurile @shawnccx @loadams