fix environment variable export bug for MultiNodeRunner #5878
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some multi-node environment like SLURM,there are some environment vars that contain special chars and can trigger errors when being exported.
For example, there is a var
SLURM_JOB_CPUS_PER_NODE=64(x2)
when requesting two nodes with 64 cpus using SLURM.Using
runner.add_export
to export this var will add a commandexport SLURM_JOB_CPUS_PER_NODE=64(x2)
when launching subprocesses, while this will cause a bash error since(
is a key word of bash, like:This PR simply wrap the environment vars with a pair of
"
to make sure they are treated as string.