Allow triton==3.0.x for fp_quantizer #6447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested with triton==3.0.x and the kernel tests pass so adding as an allowed version.
loadams
reviewed
Aug 26, 2024
loadams
reviewed
Aug 26, 2024
loadams
reviewed
Aug 27, 2024
|
@microsoft-github-policy-service agree [company="{Abacus.AI}"] |
|
@microsoft-github-policy-service agree company="Abacus.AI" |
jeffra
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
I ran tests on an H100 with triton 3.0.0 and all looks good to me. Thank you for the PR @siddartha-RE!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with triton==3.0.x and the kernel tests pass so adding as an allowed version.
Triton 2.3.x is not well supported on arm64. Triton 3.0.0 is supported on arm64 and it appears the fp8 kernel works fine with triton==3.0.0 so this simplifies usage on arm hosts (GH200).