[compile] Show breakdown of graph break #6601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohtana
approved these changes
Oct 9, 2024
tests/torch_compile/test_compile.py
Outdated
| @@ -14,22 +14,11 @@ | |||
|
|
|||
| torch._dynamo.config.cache_size_limit = 100 | |||
|
|
|||
| import collections | |||
|
|
|||
|
|
|||
| def get_dynamo_stats(): | |||
| # TODO: consider deepcopy'ing the entire counters struct and | |||
| # adding a helper to do subtraction on it | |||
There was a problem hiding this comment.
Is this comment still valid?
There was a problem hiding this comment.
Thanks for the comments, I think they should be removed. Will update.
|
Hi @tohtana the unneeded comments had been removed. Also make the workflow to count zero2, there is no graph breaks for zero2 in this simple case. https://github.com/microsoft/DeepSpeed/actions/runs/11269655884?pr=6601 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends #6570 by showing a breakdown of graph breaks. So we can see how graph breaks are distributed among different reasons. An example of graph break output can be seen from the following workflow run https://github.com/microsoft/DeepSpeed/actions/runs/11199157962