Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConvertFloat32ToFloat16: Use DirectXMath conversion functions #4855

Merged
merged 9 commits into from
Dec 15, 2022
Merged

ConvertFloat32ToFloat16: Use DirectXMath conversion functions #4855

merged 9 commits into from
Dec 15, 2022

Commits on Dec 7, 2022

  1. ConvertFloat32ToFloat16: convert value larger than max f16 to INF

    @tex3d
    tex3d committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    d6e4a67 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Change Max16In32 constant definition to make composition clear

    @tex3d
    tex3d committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    cd6f0f2 View commit details
    Browse the repository at this point in the history

  2. Update constant for largest F32 value that results in normal F16 

    Updated to OR in the float32 fractional bits, since truncation is the implied rounding mode for this function.
Updated the name to better reflect the meaning.
    @tex3d
    tex3d committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    b717a28 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2022

  1. Disable custom F16 conversion functions, using DirectXMath instead 

    Implementation of conversion stubs that pass through to DirectXMath
functions is in ExecutionTest.cpp, since all uses of these conversions
are within this cpp or ShaderOpTest.cpp which is in the same lib.

This location only depends on DirectXMath where we expect win32-only build.
    @tex3d
    tex3d committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    644537e View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Fix exception specifications on conversion functions

    @tex3d
    tex3d committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    7196f45 View commit details
    Browse the repository at this point in the history

  2. Use define to allow switching between conversion functions if desired

    @tex3d
    tex3d committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    ccdb345 View commit details
    Browse the repository at this point in the history

  3. Just remove the buggy conversion implementations

    @tex3d
    tex3d committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    73e021a View commit details
    Browse the repository at this point in the history

  4. Move conversion function stub implementations to ShaderOpTest.cpp 

    ShaderOpTest.cpp is dependency of ExecutionTest.cpp, and this is a better place for the stubs.
    @tex3d
    tex3d committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    7e51afa View commit details
    Browse the repository at this point in the history

  5. Fix comment

    @tex3d
    tex3d committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    7a1d128 View commit details
    Browse the repository at this point in the history