Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(build-tools): Include ".generated" in typetest filenames #12571

Merged
merged 3 commits into from
Oct 19, 2022

Conversation

tylerbutler
Copy link
Member

@tylerbutler tylerbutler commented Oct 19, 2022

This reverts commit 7f6cb54.

I need to do a more involved change that is easier to integrate with other release groups. In particular, the generated names need to be configurable.

@github-actions github-actions bot added the public api change Changes to a public API label Oct 19, 2022
@github-actions github-actions bot added the base: main PRs targeted against main branch label Oct 19, 2022
@github-actions github-actions bot removed the public api change Changes to a public API label Oct 19, 2022
@tylerbutler tylerbutler changed the title revert(build-cli): Configurable type test generation (#12507) revert(build-tools): Include ".generated" in typetest filenames Oct 19, 2022
@tylerbutler tylerbutler marked this pull request as ready for review October 19, 2022 01:03
@tylerbutler tylerbutler requested a review from a team as a code owner October 19, 2022 01:03
@tylerbutler tylerbutler merged commit 82637e0 into main Oct 19, 2022
@tylerbutler tylerbutler deleted the cli/revert branch October 19, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants