refactor(build-tools): Include ".generated" in typetest filenames #12484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The rename of the files is not included here since we use a published build-tools package, and not this one from the repo right? |
CraigMacomber
approved these changes
Oct 17, 2022
Correct; I'll follow up with another PR for the renames. |
tylerbutler
added a commit
that referenced
this pull request
Oct 18, 2022
#12484 updated the names of auto-generated type test files. This change prepares the eslint config for that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes generated files clear from their file name so reviewers can see the generated file warning when reviewing deltas in PRs. THis change adopts the
.generated.*convention from https://github.com/microsoft/TypeScript/wiki/Coding-guidelines#components.The fix I chose was dead-simple -- but in looking at the code I'd really like to clean the logic up more. Still, this change is simple and effective as-is.
AB#2233