Separate api for getting tenant gitManager. #14290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: server
hedasilv
approved these changes
Feb 23, 2023
manishgargd
reviewed
Feb 23, 2023
pradeepvairamani
approved these changes
Feb 24, 2023
NicholasCouri
added a commit
that referenced
this pull request
Mar 28, 2023
## Description Currently tinylicious fails to run sample scenarios in the [Share Live Repo](https://github.com/microsoft/live-share-sdk) 2 interesting commits: a) [Update deps (minor) on server release group in tinylicious (#14586) · 12b3f4c (github.com)](12b3f4c#diff-18fce4d66a0b908f502bc635b1c1377557fd7ec4f8d9df8dcaa4d9c261158ca9)) Throws when getTenantGitManager is invoked. 2) [Separate api for getting tenant gitManager. (#14290) · d368f26 (github.com)](d368f26#diff-deeaa88a2f939b81094f7412e1482709a59c4c47850a5c379c92aef0b78d70d5)) Moved the call when creating the document from getTenant to getTenantGitManager and I'm not sure if it applies to tinylicious but it is consumed by it. This PR is trying to revert the current behavior by keeping changes #2 and not throwing on #1 Repro steps: a) Clone https://github.com/microsoft/live-share-sdk b) Follow instructions from the Readme to install (I had to also install vite as it was failing without it) c) Simply try to run one of the samples (I'm using samples\javascript\03.live-canvas-demo\) http://localhost:3000/
NicholasCouri
added a commit
to NicholasCouri/FluidFramework
that referenced
this pull request
Mar 28, 2023
## Description Currently tinylicious fails to run sample scenarios in the [Share Live Repo](https://github.com/microsoft/live-share-sdk) 2 interesting commits: a) [Update deps (minor) on server release group in tinylicious (microsoft#14586) · microsoft/FluidFramework@12b3f4c (github.com)](microsoft@12b3f4c#diff-18fce4d66a0b908f502bc635b1c1377557fd7ec4f8d9df8dcaa4d9c261158ca9)) Throws when getTenantGitManager is invoked. 2) [Separate api for getting tenant gitManager. (microsoft#14290) · microsoft/FluidFramework@d368f26 (github.com)](microsoft@d368f26#diff-deeaa88a2f939b81094f7412e1482709a59c4c47850a5c379c92aef0b78d70d5)) Moved the call when creating the document from getTenant to getTenantGitManager and I'm not sure if it applies to tinylicious but it is consumed by it. This PR is trying to revert the current behavior by keeping changes microsoft#2 and not throwing on microsoft#1 Repro steps: a) Clone https://github.com/microsoft/live-share-sdk b) Follow instructions from the Readme to install (I had to also install vite as it was failing without it) c) Simply try to run one of the samples (I'm using samples\javascript\03.live-canvas-demo\) http://localhost:3000/
NicholasCouri
added a commit
that referenced
this pull request
Mar 29, 2023
## Description Currently tinylicious fails to run sample scenarios in the [Share Live Repo](https://github.com/microsoft/live-share-sdk) 2 interesting commits: a) [Update deps (minor) on server release group in tinylicious (#14586) · 12b3f4c (github.com)](12b3f4c#diff-18fce4d66a0b908f502bc635b1c1377557fd7ec4f8d9df8dcaa4d9c261158ca9)) Throws when getTenantGitManager is invoked. 2) [Separate api for getting tenant gitManager. (#14290) · d368f26 (github.com)](d368f26#diff-deeaa88a2f939b81094f7412e1482709a59c4c47850a5c379c92aef0b78d70d5)) Moved the call when creating the document from getTenant to getTenantGitManager and I'm not sure if it applies to tinylicious but it is consumed by it. This PR is trying to revert the current behavior by keeping changes #2 and not throwing on #1 Repro steps: a) Clone https://github.com/microsoft/live-share-sdk b) Follow instructions from the Readme to install (I had to also install vite as it was failing without it) c) Simply try to run one of the samples (I'm using samples\javascript\03.live-canvas-demo\) http://localhost:3000/
tylerbutler
added a commit
to tylerbutler/FluidFramework
that referenced
this pull request
Mar 29, 2023
This reverts commit d368f26.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How contribute to this repo.
Guidelines for Pull Requests.
The sections included below are suggestions for what you may want to include.
Feel free to remove or alter parts of this template that do not offer value for your specific change.
Description
A lot of consumers of TenantManager.getTenant() across the Server codebase need only the GitManager property of the returned ITenant object. Constructing a tenant GitManager instance requires only the tenant keys (which are already being cached), while retrieving the tenant data involves a call to tenant DB. This change refactors out the tenant GitManager instance construction into a separate API and switches the callers of TenantManager.getTenant() that consume only the GitManager property to this new API, so that they do not unnecessarily incur a tenant DB call.
Breaking Changes
Reviewer Guidance
The review process is outlined on this wiki page.