-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Client Deps #21983
base: main
Are you sure you want to change the base?
Update Client Deps #21983
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a generally good update to me.
There appear to be more removed packages than added. Some number of needlessly duplicated packages are now consolidated.
Hopefully there are fewer deprecation warning with these updates, but likely we'll need more focused effort to update beyond a number of them.
Looks like syncpack objects to me setting an override to pin the api extractor version. I guess I need to update the dep in every package instead of using an override. Thats harder to document and a much larger change, but maybe better. |
…ke syncpack happy
This PR has been automatically marked as stale because it has had no activity for 60 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework! |
Description
This regenerates the client lock file.
Regenerating the workspace lock file helps detect issues where our dependency specifications are incorrect, as well as provides a way to update our deps to what a customer would get when creating a new project which helps us test more realistic usage.
This found an issue where we have a patch to API extractor, but don't pin the version, so if it gets updated, we can pull in that update breaking the patch. This change pins the version to match the patch since the updates to not include the fix we are patching.
Reviewer Guidance
The review process is outlined on this wiki page.
Questions: