Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Client Deps #21983

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

CraigMacomber
Copy link
Contributor

@CraigMacomber CraigMacomber commented Jul 22, 2024

Description

This regenerates the client lock file.

Regenerating the workspace lock file helps detect issues where our dependency specifications are incorrect, as well as provides a way to update our deps to what a customer would get when creating a new project which helps us test more realistic usage.

This found an issue where we have a patch to API extractor, but don't pin the version, so if it gets updated, we can pull in that update breaking the patch. This change pins the version to match the patch since the updates to not include the fix we are patching.

rm ./pnpm-lock.yaml 
rm -r ./node_modules/
pnpm install --no-frozen-lockfile

Reviewer Guidance

The review process is outlined on this wiki page.

Questions:

  • Is this a good thing to do now? It made less of an impact than I expected: often we accumulate a ton do duplicated versions and doing this shrinks the install a lot, but it only shrunk a bit this time.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Jul 22, 2024
Copy link
Contributor

@jason-ha jason-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a generally good update to me.
There appear to be more removed packages than added. Some number of needlessly duplicated packages are now consolidated.
Hopefully there are fewer deprecation warning with these updates, but likely we'll need more focused effort to update beyond a number of them.

@CraigMacomber
Copy link
Contributor Author

Looks like syncpack objects to me setting an override to pin the api extractor version. I guess I need to update the dep in every package instead of using an override. Thats harder to document and a much larger change, but maybe better.

@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: propertydds area: dds: sharedstring area: dds: tree area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc labels Jul 23, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has had no activity for 60 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: propertydds area: dds: sharedstring area: dds: tree area: dds Issues related to distributed data structures area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch dependencies Pull requests that update a dependency file status: stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants