Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SWIG][mmlspark] fix seg fault in LGBM_BoosterGetEvalNamesSWIG #2958

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

imatiach-msft
Copy link
Contributor

fix seg fault in LGBM_BoosterGetEvalNamesSWIG

@imatiach-msft
Copy link
Contributor Author

tagging @AlbertoEAF - this issue was causing a seg fault when I tried to update to the new LGBM_BoosterGetEvalNamesSWIG API
also adding @StrikerRUS @guolinke for review

@imatiach-msft imatiach-msft changed the title fix seg fault in LGBM_BoosterGetEvalNamesSWIG [SWIG][mmlspark] fix seg fault in LGBM_BoosterGetEvalNamesSWIG Mar 30, 2020
Copy link
Contributor

@AlbertoEAF AlbertoEAF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @imatiach-msft !

@imatiach-msft
Copy link
Contributor Author

@StrikerRUS @guolinke can the fix be merged - I can't update to latest right now because of the regression. Thank you!

@StrikerRUS StrikerRUS merged commit 6ba84d5 into microsoft:master Apr 1, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants