-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] refactor and improvements to lgb.convert() functions (fixes #2678, #2681) #3269
Conversation
Yeah, i think it is great |
ok thanks! I can do that |
I just removed |
@guolinke I'll merge |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This PR fixes #2678 and #2681 by adding the following improvements to
lgb.convert()
functions:lgb.convert()
:lgb.convert_with_rules()
:rules
no longer contains rules where the "name" in the rule is a missing valuelogical
columns tointeger
, filling in missing values with -1numeric
orinteger
inherits(data, "data.table")
todata.table::is.data.table()
Question for reviewers
@Laurae2 @guolinke could we remove
lgb.convert()
and just offerlgb.convert_with_rules()
? Usinglgb.convert_with_rules()
without passing your own rules (the default), has identical behavior tolgb.convert()
and is better because it returns therules
on how columns were changed, which improves reproducibility. Since we're considering a3.0.0
release in #3071 right now, I think this is the right time for such a breaking change.