3.1.0 release #3484

guolinke · 2020-10-26T04:32:38Z

No description provided.

guolinke · 2020-10-26T05:09:46Z

I think following PRs could be included in this release:

for the remaining, we may need more times to review/implement.

StrikerRUS · 2020-10-26T12:12:48Z

I think #3428 should be merged only after fixing this CUDA error #3450.

Also, I'd like to include in 3.1 a fix for easy-reproducible OpenCL GPU error #3475 .

jameslamb · 2020-10-26T14:19:59Z

Works for me! Other than the pull requests already mentioned, I have nothing to add that I think needs to get in for the release. And I agree with the next release being 3.1.0 instead of 3.0.1, since so many new features have been added.

Once those other pull requests mentioned above have all been merged, I'll run all the CRAN checks (manual valgrind check here, Solaris via R Hub) to be sure no new issues have been introduced.

We won't be able to submit the R package to CRAN until November but I'm ok with doing the rest of the release before then and not waiting on CRAN. Also as a reminder from #3338 ...I'll do the CRAN submission this time.

jameslamb · 2020-10-27T03:52:32Z

@guolinke I hope it's ok, I updated R-package/configure and pushed it here

StrikerRUS · 2020-10-28T00:15:47Z

jameslamb · 2020-10-28T02:57:29Z

As of #3335, Update version and release date in DESCRIPTION file of R-package. is no longer necessary for releases 😀

StrikerRUS · 2020-10-28T13:01:28Z

@jameslamb Cool! Then I'm striking this bullet out from the list.

guolinke · 2020-11-01T02:33:57Z

@shiyu1994 what is the ETA of your improvement for dense histogram construction? I think this PR is waiting for it.

StrikerRUS · 2020-11-02T18:51:51Z

I've marked #3520 as blocking issue, I think we can include fix for it in 3.1.0.

jameslamb · 2020-11-03T22:46:41Z

I'm sorry, I just discovered a valgrind issue that I think will block 3.1.0 from getting to CRAN: #3525

UPDATE: fixed in #3526

jameslamb · 2020-11-07T05:44:05Z

Now that all of the PRs in #3484 (comment) have been fixed, if CI passes are we ready to release? Should I submit the R package to CRAN?

jameslamb · 2020-11-07T05:44:23Z

R-package/configure

@@ -1,6 +1,6 @@
 #! /bin/sh
 # Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.69 for lightgbm 3.0.0.99.
+# Generated by GNU Autoconf 2.69 for lightgbm 3.1.0.


/gha run r-valgrind

this passed: https://github.com/microsoft/LightGBM/actions/runs/350733081

/gha build r-artifacts

looks like this job is broken:

Error: Input 'submodules' not supported when falling back to download using the GitHub REST API. To create a local Git repository instead, add Git 2.18 or higher to the PATH.

run: https://github.com/microsoft/LightGBM/runs/1404264739?check_suite_focus=true

I opened #3567. It doesn't have to be fixed for the release. I can build the package locally.

jameslamb · 2020-11-07T05:46:05Z

oh wait I forgot about #3513. I'll open a PR right now that skips the problematic tests for now.

StrikerRUS · 2020-11-07T18:56:07Z

if CI passes are we ready to release?

What about #3484 (comment) (#3475)?

StrikerRUS · 2020-11-07T19:29:46Z

Also, I'd like to mark this release as the last one which supports Python 2. So that our next minor release (in 2021 I believe) will drop Python 2 support (1 year after Python 2 EOL). I guess it's time. Does anyone have any objections?

guolinke · 2020-11-15T14:44:01Z

I am going to merge this in 24 hours and draft a new release.

guolinke · 2020-11-16T02:14:34Z

@jameslamb Any cran's issuse to address? I think we can submit this release to cran.

jameslamb · 2020-11-16T02:23:56Z

@jameslamb Any cran's issuse to address? I think we can submit this release to cran.

I'll try R Hub Solaris checks on this branch one more time right now. I think some things have been merged here since the last time I did that.

If those checks pass (should only take 10-20 minutes), I'll submit a CRAN submission. Is that OK?

guolinke · 2020-11-16T02:38:49Z

@jameslamb no problem, thank you!

jameslamb · 2020-11-16T02:58:13Z

no issues found on Solaris (https://artifacts.r-hub.io/lightgbm_3.1.0.tar.gz-048076e707fd42c695b805753f65aa44/lightgbm.Rcheck/), valgrind is happy (#3484 (comment)), and all of the other CI jobs are passing.

I'm going to submit to CRAN 😀

@guolinke I think that since I'm not the maintainer in DESCRIPTION, CRAN will email you to confirm that I have permission to submit.

jameslamb · 2020-11-16T03:26:42Z

I've submitted to CRAN!

@guolinke they'll send you an email next asking you to confirm the submission

The maintainer of this package has been sent an email to confirm the submission. After their confirmation the package will be passed to CRAN for review.

Please note that the submission is not completed until it is confirmed by the maintainer (via a link in the e-mail), who may need to check the spam folder.

guolinke · 2020-11-16T04:33:37Z

StrikerRUS · 2020-11-16T12:39:44Z

@guolinke

can you help for the Homebrew formula?

Sure. PR proposed: Homebrew/homebrew-core#64933

Seems Homebrew started to support Big Sur! 👍

Homebrew/homebrew-core@d80a8b5#diff-5e461287a37b620a7dd2f18a9c1706d10371608f3384c032bb732aa2a08117f6

StrikerRUS · 2020-11-16T23:10:25Z

PR proposed: Homebrew/homebrew-core#64933

Homebrew successfully updated:

jameslamb · 2020-11-16T23:16:03Z

woo, thanks!

jameslamb · 2020-11-18T04:16:10Z

@guolinke have you received an email from CRAN?

According to https://lockedata.github.io/cransays/articles/dashboard.html, {lightgbm} is still in "pending" which means CRAN is waiting for a response from us. They should have sent you an email with a link to click to confirm that I'm allowed to submit.

guolinke · 2020-11-18T08:05:17Z

I think I already comfirm it and receive their auto reply:

Dear maintainer,
 
package lightgbm_3.1.0.tar.gz has been auto-processed and is pending a manual inspection of this new CRAN submission. A CRAN team member will typically respond to you within the next 10 working days. For technical reasons you may receive a second copy of this message when a team member triggers a new check.
 
Log dir: <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwin-builder.r-project.org%2Fincoming_pretest%2Flightgbm_3.1.0_20201116_044056%2F&amp;data=04%7C01%7Cguolin.ke%40microsoft.com%7Cbe31c3b4f887472079fe08d88a006d6d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637411081749888900%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=NZe%2BwpgRf5A%2FTfQy1OZIIvl2y1DORnbdUFb4YZyZ5N8%3D&amp;reserved=0>
The files will be removed after roughly 7 days.
Installation time in seconds: 676
Check time in seconds: 256 
R Under development (unstable) (2020-11-14 r79432)
 
Pretests results:
Windows: <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwin-builder.r-project.org%2Fincoming_pretest%2Flightgbm_3.1.0_20201116_044056%2FWindows%2F00check.log&amp;data=04%7C01%7Cguolin.ke%40microsoft.com%7Cbe31c3b4f887472079fe08d88a006d6d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637411081749888900%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=MfQWw19iM7fjFNw5HhQXZtB4LmyLvHRMuiIQeaNWl%2B8%3D&amp;reserved=0>
Status: 1 NOTE
Debian: <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwin-builder.r-project.org%2Fincoming_pretest%2Flightgbm_3.1.0_20201116_044056%2FDebian%2F00check.log&amp;data=04%7C01%7Cguolin.ke%40microsoft.com%7Cbe31c3b4f887472079fe08d88a006d6d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637411081749898895%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=nYwviy5FXgrR0wgBAeFd1aGe%2BC8f3WnK%2BAz4ZhBRV5A%3D&amp;reserved=0>
Status: 1 NOTE
 

 
No strong reverse dependencies to be checked.
 
Best regards,
CRAN teams' auto-check service

jameslamb · 2020-11-18T15:11:33Z

oh great, thank you!

guolinke · 2020-11-19T02:26:42Z

It seems we got accept:
https://cran.r-project.org/web/packages/lightgbm/index.html

But the checks are not updated yet: https://cran.r-project.org/web/checks/check_results_lightgbm.html

jameslamb · 2020-11-19T04:39:16Z

!!! Exciting!

I'm going to wait a few days before publicizing this or updating the documentation, in case we get surprised like last time.

But I'm hopeful 😀

jameslamb · 2020-11-19T20:00:27Z

I've been refreshing https://cran.r-project.org/web/checks/check_results_lightgbm.html every few hours. More checks are slowly rolling in.

Right now we're passing on Windows, Mac, Solaris, and Linux

Soon we should know if we're passing valgrind and UBSAN/ASAN, as well as tests with other combinations of operating system + compiler.

StrikerRUS · 2020-11-21T14:55:24Z

@jameslamb According to https://cran.r-project.org/web/checks/check_results_lightgbm.html it looks like we need to add ON_32BIT_WIN to the fix introduced in #3534.

https://github.com/dmlc/xgboost/blob/cf4f019ed63b94a8ba15d854a44feeaeeec385b0/R-package/tests/testthat/test_basic.R#L11-L13

jameslamb · 2020-11-21T22:57:08Z

UGH

Ok I'll open a PR with a fix. I think to be safe we should just completely skip that test if on CRAN. This also tells me the existing Windows CI jobs we have in GitHub Actions aren't a perfect replica of what CRAN does.

I'll see if I can replicate it with R Hub.

jameslamb · 2020-11-21T23:19:10Z

I created #3585 , let's move this discussion there instead of keeping it on this closed PR

StrikerRUS · 2020-11-21T23:54:53Z

This also tells me the existing Windows CI jobs we have in GitHub Actions aren't a perfect replica of what CRAN does.

I guess we simply don't have any 32-bit CI jobs.

github-actions · 2023-08-24T04:02:30Z

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

Update VERSION.txt

8fee352

guolinke requested review from jameslamb, Laurae2 and StrikerRUS as code owners October 26, 2020 04:32

guolinke changed the title ~~Update VERSION.txt~~ 3.1.0 release Oct 26, 2020

jameslamb mentioned this pull request Oct 26, 2020

ValueError: For early stopping, at least one dataset and eval metric is required for evaluation #3028

Closed

update configure

138d8b3

Update .appveyor.yml

568c041

jameslamb mentioned this pull request Oct 31, 2020

[R-package] fix MM_PREFETCH and MM_MALLOC checks in configure.ac #3510

Merged

jameslamb mentioned this pull request Nov 1, 2020

[R-package] learning-to-rank tests are broken on Solaris 10 and 32-bit Windows #3513

Open

jameslamb mentioned this pull request Nov 3, 2020

[R-package] invalid read detected by valgrind #3525

Closed

Merge branch 'master' into 3.1.0-release

b3e7a01

jameslamb reviewed Nov 7, 2020

View reviewed changes

jameslamb mentioned this pull request Nov 7, 2020

[R-package] fix learning-to-rank tests on Solaris #3534

Merged

StrikerRUS mentioned this pull request Nov 7, 2020

[RFC] version changes + more frequent releases #3210

Closed

StrikerRUS requested a review from henry0312 November 7, 2020 19:30

StrikerRUS approved these changes Nov 15, 2020

View reviewed changes

update cran-comments

cf9e5cd

guolinke merged commit 0b5e60d into master Nov 16, 2020

StrikerRUS deleted the 3.1.0-release branch November 16, 2020 12:25

StrikerRUS mentioned this pull request Nov 16, 2020

v3.1.0 missing CRAN package #3569

Closed

jameslamb mentioned this pull request Nov 16, 2020

[ci] Remove Python 2.7 CI jobs #3572

Closed

jameslamb mentioned this pull request Nov 21, 2020

[R-package] tests fail on 32-bit Windows, R-oldrel #3585

Closed

StrikerRUS mentioned this pull request Nov 26, 2020

[R-package][tests] update values in valgrind test #3600

Merged

github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023

3.1.0 release #3484

3.1.0 release #3484

Conversation

guolinke commented Oct 26, 2020

guolinke commented Oct 26, 2020 • edited Loading

StrikerRUS commented Oct 26, 2020

jameslamb commented Oct 26, 2020

jameslamb commented Oct 27, 2020

StrikerRUS commented Oct 28, 2020 • edited Loading

Release checklist:

jameslamb commented Oct 28, 2020

StrikerRUS commented Oct 28, 2020

guolinke commented Nov 1, 2020

StrikerRUS commented Nov 2, 2020

jameslamb commented Nov 3, 2020 • edited Loading

jameslamb commented Nov 7, 2020

jameslamb Nov 7, 2020

Choose a reason for hiding this comment

jameslamb Nov 7, 2020

Choose a reason for hiding this comment

jameslamb Nov 16, 2020

Choose a reason for hiding this comment

jameslamb Nov 16, 2020

Choose a reason for hiding this comment

jameslamb commented Nov 7, 2020

StrikerRUS commented Nov 7, 2020

StrikerRUS commented Nov 7, 2020

guolinke commented Nov 15, 2020

guolinke commented Nov 16, 2020

jameslamb commented Nov 16, 2020

guolinke commented Nov 16, 2020

jameslamb commented Nov 16, 2020

jameslamb commented Nov 16, 2020

guolinke commented Nov 16, 2020

Release checklist:

StrikerRUS commented Nov 16, 2020

StrikerRUS commented Nov 16, 2020

jameslamb commented Nov 16, 2020

jameslamb commented Nov 18, 2020

guolinke commented Nov 18, 2020

jameslamb commented Nov 18, 2020

guolinke commented Nov 19, 2020 • edited Loading

jameslamb commented Nov 19, 2020

jameslamb commented Nov 19, 2020

StrikerRUS commented Nov 21, 2020 • edited Loading

jameslamb commented Nov 21, 2020

jameslamb commented Nov 21, 2020

StrikerRUS commented Nov 21, 2020

github-actions bot commented Aug 24, 2023

guolinke commented Oct 26, 2020 •

edited

Loading

StrikerRUS commented Oct 28, 2020 •

edited

Loading

jameslamb commented Nov 3, 2020 •

edited

Loading

guolinke commented Nov 19, 2020 •

edited

Loading

StrikerRUS commented Nov 21, 2020 •

edited

Loading