Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R-package] avoid unnecessary computation and add tests for Dataset set_reference() method #4587

Merged
merged 8 commits into from
Sep 10, 2021
Merged

[R-package] avoid unnecessary computation and add tests for Dataset set_reference() method #4587

merged 8 commits into from
Sep 10, 2021

Commits on Sep 2, 2021

  1. [R-package] avoid unnecessary computation in Dataset set_reference() … 

    …method
    @jameslamb
    jameslamb committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    912be29 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into r/self-reference

    @jameslamb
    jameslamb committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    5d4d174 View commit details
    Browse the repository at this point in the history

  3. re-arrange conditions

    @jameslamb
    jameslamb committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    a4d9300 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into r/self-reference

    @jameslamb
    jameslamb committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    24ee8de View commit details
    Browse the repository at this point in the history

  5. do more validation upfront and add tests

    @jameslamb
    jameslamb committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    8703a73 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. Merge branch 'master' into r/self-reference

    @StrikerRUS
    StrikerRUS committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    e5e3e0b View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. Update R-package/tests/testthat/test_dataset.R 

    Co-authored-by: Nikita Titov <[email protected]>
    @jameslamb @StrikerRUS
    jameslamb and StrikerRUS authored Sep 10, 2021
    Configuration menu
    Copy the full SHA
    e0889ee View commit details
    Browse the repository at this point in the history

  2. Update R-package/tests/testthat/test_dataset.R

    @jameslamb
    jameslamb authored Sep 10, 2021
    Configuration menu
    Copy the full SHA
    9daae12 View commit details
    Browse the repository at this point in the history