remove unused BinMapper::SizeForSpecificBin() #4643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
requested review from
btrotta,
chivee,
guolinke and
shiyu1994
as code owners
StrikerRUS
approved these changes
Oct 3, 2021
There was a problem hiding this comment.
Thanks for the cleanup!
The usage of this method was dropped in #2485:
https://github.com/microsoft/LightGBM/pull/2485/files#diff-85e23cbc42ffa687f2c8a01ec3cb414cfe99b95a72d3df5d45b10bdc523f6784L684
shiyu1994
approved these changes
Oct 4, 2021
16 tasks
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cppcheckshows the following warning (#4539 (comment))I confirmed that this method is not called anywhere in the library, using
git grep SizeForSpecificBin. I think it's safe to remove, since only the code insrc/c_api.cppis considered parrt of the public API for LightGBM.I also double-checked and don't see this method referenced in the in-progress CUDA work (#4528, #4630).
Notes for Reviewers
I checked the git blame to see if this method had been added for a specific purpose in the past, but don't see anything like that. It was part of the first commit on the project.
https://github.com/microsoft/LightGBM/blame/7a82ba4ffcca8530e53b75f148429978653a57c3/include/LightGBM/bin.h#L153