[python] reset storage in record evaluation callback each time before starting training #4885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
commented
Dec 12, 2021
| @@ -319,6 +322,7 @@ def test_grid_search(): | |||
| assert grid.best_estimator_.best_score_['valid_0']['error'] == 0 | |||
| assert score >= 0.2 | |||
| assert score <= 1. | |||
| assert evals_result == grid.best_estimator_.evals_result_ | |||
There was a problem hiding this comment.
This assert fails at master:
> assert evals_result == grid.best_estimator_.evals_result_
E AssertionError: assert {'valid_0': O..., 0, 0, 0])])} == {'valid_0': O... [0, 0, 0])])}
E Differing items:
E {'valid_0': OrderedDict([('multi_logloss', [0.5915701709051111, 0.5814219901209461, 0.6047065388140261, 0.555159764382..., 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0])])} != {'valid_0': OrderedDict([('multi_logloss', [0.11975431959688579, 0.11424123104047454, 0.11872456319439122]), ('error', [0, 0, 0])])}
https://github.com/microsoft/LightGBM/runs/4499752025?check_suite_focus=true#step:3:834
StrikerRUS
requested review from
chivee,
henry0312,
hzy46,
jameslamb,
shiyu1994 and
tongwu-sh
as code owners
13 tasks
40 tasks
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to #4868.
Also, simplify early stopping callback by unconditionally reset all storages at the first iteration. This is much easier than tracking
initednonlocal flag (refer to #4868 (comment)).