Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce duplicate computation in poisson, gamma, and tweedie objectives #4950

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

lorentzenchr
Copy link
Contributor

This PR introduces temporaries to save some compuations of std::exp in the regression objectives, namely Poisson, Gamma and Tweedie.

@ghost
Copy link

ghost commented Jan 15, 2022

CLA assistant check
All CLA requirements met.

@jameslamb jameslamb self-requested a review January 15, 2022 18:11
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your interest in LightGBM!

@lorentzenchr can you please edit the description of this PR to include an explanation of why you'd like to make these changes?

Is the goal mainly to avoid duplicated computation, to speed up calculation of these objectives?

UPD: never mind, I see what you meant now by "save computation". Thank you!

Let me know if you need help understanding how to fix the failing CI jobs.

@lorentzenchr
Copy link
Contributor Author

CI is green now.

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution!

@jameslamb jameslamb self-requested a review January 19, 2022 04:32
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, thanks for your help!

@jameslamb jameslamb changed the title ENH save computations of exp in objectives reduce duplicate computation in poisson, gamma, and tweedie objectives Jan 19, 2022
@StrikerRUS StrikerRUS merged commit f85dfa2 into microsoft:master Jan 20, 2022
@lorentzenchr lorentzenchr deleted the save_exp_computation branch January 20, 2022 10:04
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@lorentzenchr
Copy link
Contributor Author

@jameslamb @StrikerRUS The following was brought to my attention: Should this PR be listed in the release notes of https://github.com/microsoft/LightGBM/releases/tag/v4.0.0?

@jameslamb
Copy link
Collaborator

@lorentzenchr it is already.

Screenshot 2023-07-28 at 8 36 14 AM

Are you seeing something different?

@lorentzenchr
Copy link
Contributor Author

@jameslamb I'm so sorry, my browser tricked me somehow.

@jameslamb
Copy link
Collaborator

No problem, it's a VERY long page of release notes for this particular release 😂 .

Thanks as always for your contributions here!

Copy link

github-actions bot commented Nov 1, 2023

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants