Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] fix broken links in docs #5939

Merged
merged 1 commit into from
Jun 23, 2023
Merged

[docs] fix broken links in docs #5939

merged 1 commit into from
Jun 23, 2023

Conversation

jameslamb
Copy link
Collaborator

The check-links CI job has been broken for a while. (most recent build link).

This PR fixes the 3 errors:

URL        `https://www.tandfonline.com/doi/abs/10.1080/01621459.1958.10501479'
Name       `Fisher (1958)'
Parent URL file:///home/runner/work/LightGBM/LightGBM/docs/_build/html/Advanced-Topics.html, line 120, col 1
Real URL   https://www.tandfonline.com/doi/abs/10.1080/01621459.1958.10501479
Check time 0.230 seconds
Result     Error: 403 Forbidden
URL        `https://docs.pymars.org/en/latest/index.html'
Name       `Mars'
Parent URL file:///home/runner/work/LightGBM/LightGBM/docs/_build/html/Parallel-Learning-Guide.html, line 543, col 4
Real URL   https://docs.pymars.org/en/latest/index.html
Check time 0.718 seconds
Result     Error: ConnectionError: HTTPSConnectionPool(host='docs.pymars.org', port=443): Max retries exceeded with url: /en/latest/index.html (Caused by NameResolutionError("<urllib3.connection.HTTPSConnection object at 0x7f316bf6ee50>: Failed to resolve 'd...
URL        `https://docs.pymars.org/en/latest/user_guide/learn/lightgbm.html'
Name       `the mars documentation'
Parent URL file:///home/runner/work/LightGBM/LightGBM/docs/_build/html/Parallel-Learning-Guide.html, line 544, col 8
Real URL   https://docs.pymars.org/en/latest/user_guide/learn/lightgbm.html
Check time 4.392 seconds
Result     Error: ConnectionError: HTTPSConnectionPool(host='docs.pymars.org', port=443): Max retries exceeded with url: /en/latest/user_guide/learn/lightgbm.html (Caused by NameResolutionError("<urllib3.connection.HTTPSConnection object at 0x7f316bf6e6a0>: ...

@@ -9,6 +9,7 @@ threads=1
ignore=
pythonapi/lightgbm\..*\.html.*
http.*amd.com/.*
https.*tandfonline.com/.*
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm able to navigate to https://www.tandfonline.com/doi/abs/10.1080/01621459.1958.10501479 in my browser without issue, and without being signed in to that website.

image

But curl -I (which issues a HEAD request), returns a 403 - Access Denied.

(lgb-dev) 😬 ./LightGBM $ curl -I https://www.tandfonline.com/doi/abs/10.1080/01621459.1958.10501479
HTTP/2 403
date: Fri, 23 Jun 2023 04:59:22 GMT
content-type: text/html; charset=UTF-8
cross-origin-embedder-policy: require-corp
cross-origin-opener-policy: same-origin
cross-origin-resource-policy: same-origin
permissions-policy: accelerometer=(),autoplay=(),camera=(),clipboard-read=(),clipboard-write=(),geolocation=(),gyroscope=(),hid=(),interest-cohort=(),magnetometer=(),microphone=(),payment=(),publickey-credentials-get=(),screen-wake-lock=(),serial=(),sync-xhr=(),usb=()
referrer-policy: same-origin
x-frame-options: SAMEORIGIN
cf-mitigated: challenge
cache-control: private, max-age=0, no-store, no-cache, must-revalidate, post-check=0, pre-check=0
expires: Thu, 01 Jan 1970 00:00:01 GMT
strict-transport-security: max-age=15552000
server: cloudflare
cf-ray: 7dba29492ca810b3-ORD
alt-svc: h3=":443"; ma=86400

Looks like that site is behind CloudFlare, so the link checks are probably triggering some anti-DDoS protection 🤷🏻

This configuration change tells the check-links CI job to ignore that domain.

A similar issue with amd.com links was fixed by doing this same thing in the past here:

@jameslamb jameslamb merged commit 22c09f9 into master Jun 23, 2023
@jameslamb jameslamb deleted the docs/fix-links branch June 23, 2023 15:34
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants