[docs] Add scikit-learn for intersphinx (fixes #5954) #5956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
changed the title
jameslamb
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
This is great, thanks so much @thomasjpfan !
I think this is a much better solution than what I proposed in scikit-learn/scikit-learn#26747. It's lightweight for any project to implement, and gives a much stronger guarantee of being future-proof against future changes upstream in scikit-learn.
Appreciate you taking the time to open this 😊
sachaMorin
added a commit
to Labo-Lacourse/stepmix
that referenced
this pull request
Jul 5, 2023
Recent sklearn changes to BaseEstimator seems to break the documentation. See microsoft/LightGBM#5956.
fernandezfran
added a commit
to fernandezfran/galpynostatic
that referenced
this pull request
Jul 5, 2023
8 tasks
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5954
This PR enables Sphinx's intersphinx extension such that links to scikit-learn's docs can be resolved. Note that the sphinx.ext.intersphinx extension comes with Sphinx.