Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python-package] No warning if single alias of num_boost_round is passed #6548

Closed
wants to merge 3 commits into from
Closed

[python-package] No warning if single alias of num_boost_round is passed #6548

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59f0051
No warning if single alias of num_boost_round is passed
Jul 16, 2024
4e2cf27
Fixing IndexError
Jul 18, 2024
3463063
Merge branch 'microsoft:master' into master
vnherdeiro Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions python-package/lightgbm/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,10 @@ def train(
if callable(params["objective"]):
fobj = params["objective"]
params["objective"] = "none"
for alias in _ConfigAliases.get("num_iterations"):
if alias in params:
num_boost_round = params.pop(alias)
_log_warning(f"Found `{alias}` in params. Will use it instead of argument")
num_boost_round_aliases = [alias for alias in _ConfigAliases.get("num_iterations") if alias in params]
num_boost_round = params.pop(num_boost_round_aliases[-1])
if num_boost_round_aliases[:-1]:
_log_warning(f"Found `{num_boost_round_aliases[-1]}` in params. Will use it instead of `{num_boost_round_aliases[:-1]}`")
params["num_iterations"] = num_boost_round
# setting early stopping via global params should be possible
params = _choose_param_value(
Expand Down
Loading