Set IncludeBuildOutput to false in NoTargets (#117)

This ensures the Pack task does not attempt to include build output from a NoTargets project since it won't emit an assembly. Fixes #116
microsoft · Jul 11, 2019 · 58d934f · 58d934f
1 parent 35ebaff
commit 58d934f
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/src/NoTargets.UnitTests/NoTargetsTests.cs b/src/NoTargets.UnitTests/NoTargetsTests.cs
@@ -38,6 +38,17 @@ public void EnableDefaultEmbeddedResourceItemsIsFalse()
             enableDefaultEmbeddedResourceItems.ShouldBe("false");
         }
 
+        [Fact]
+        public void IncludeBuildOutputIsFalseByDefault()
+        {
+            ProjectCreator.Templates.NoTargetsProject(
+                    path: GetTempFileWithExtension(".csproj"))
+                .Save()
+                .TryGetPropertyValue("IncludeBuildOutput", out string includeBuildOutput);
+
+            includeBuildOutput.ShouldBe("false");
+        }
+
         [Fact]
         public void SimpleBuild()
         {

diff --git a/src/NoTargets/Sdk/Sdk.targets b/src/NoTargets/Sdk/Sdk.targets
@@ -21,6 +21,11 @@
 
   <Import Project="$(CustomBeforeNoTargets)" Condition="'$(CustomBeforeNoTargets)' != '' and Exists('$(CustomBeforeNoTargets)')" />
 
+  <PropertyGroup>
+    <!-- Don't include build output in a package since NoTargets projects don't emit an assembly. -->
+    <IncludeBuildOutput Condition="'$(IncludeBuildOutput)' == ''">false</IncludeBuildOutput>
+  </PropertyGroup>
+
   <Import Project="Sdk.targets" Sdk="Microsoft.NET.Sdk" Condition=" '$(CommonTargetsPath)' == '' " />
 
   <ItemGroup>