Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Artifacts item name should be just Artifact #105

Closed
jeffkl opened this issue Jun 14, 2019 · 0 comments · Fixed by #106
Closed

Artifacts item name should be just Artifact #105

jeffkl opened this issue Jun 14, 2019 · 0 comments · Fixed by #106
Labels
Bug Something isn't working

Comments

@jeffkl
Copy link
Contributor

jeffkl commented Jun 14, 2019

The document references an <Artifact /> item but what's actually in use is <Artifacts />. It is more common for item names to be singular. So the item name should be <Artifact /> which is a breaking change and will require a new major version.
@jeffkl jeffkl added the Bug Something isn't working label Jun 14, 2019
@jeffkl jeffkl mentioned this issue Jun 14, 2019
Merged
jeffkl added a commit that referenced this issue Jun 14, 2019
@jeffkl
Use item Artifact intead of Artifacts (#106)
6e47c1a 
* Update version to 2.0
* Update README with information about the breaking change

Fixes #105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use item Artifact intead of Artifacts jeffkl/MSBuildSdks
1 participant
@jeffkl