Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow loading .msbuildproj in VS using Traversal #206

Closed
kzu opened this issue Oct 5, 2020 · 3 comments · Fixed by #211
Closed

Allow loading .msbuildproj in VS using Traversal #206

kzu opened this issue Oct 5, 2020 · 3 comments · Fixed by #211
Labels
Feature Request New feature or request

Comments

@kzu
Copy link
Contributor

kzu commented Oct 5, 2020

Similar to #97 but for Traversal.

I can back-port #98 if folks think it's worth it. I think it is, brings more consistency with NoTargets too :).
@jeffkl
Copy link
Contributor

jeffkl commented Oct 5, 2020

Sounds like a good improvement, feel free to send a PR!

@jeffkl jeffkl added the Feature Request New feature or request label Oct 5, 2020
@kzu
Copy link
Contributor Author

kzu commented Oct 6, 2020

Will do. Thanks!

kzu added a commit to kzu/MSBuildSdks that referenced this issue Oct 8, 2020
@kzu
Allow loading .msbuildproj in VS using Traversal SDK
35ce27f 
By including the design-time targets and imports expected by CPS, we
allow the full loading and editing experience in the IDE automatically.

Fixes microsoft#206
@kzu kzu mentioned this issue Oct 8, 2020
Merged
@kzu
Copy link
Contributor Author

kzu commented Oct 8, 2020

PR sent! 👍

jeffkl pushed a commit that referenced this issue Oct 8, 2020
@kzu
Allow loading .msbuildproj in VS using Traversal SDK (#211)
5933d25 
By including the design-time targets and imports expected by CPS, we
allow the full loading and editing experience in the IDE automatically.

Fixes #206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow loading .msbuildproj in VS using Traversal SDK kzu/MSBuildSdks
2 participants
@kzu @jeffkl