Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not build when --no-build is specified #126

Merged
merged 1 commit into from
Aug 19, 2019
Merged

Do not build when --no-build is specified #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
129 changes: 80 additions & 49 deletions src/Traversal.UnitTests/TraversalTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,37 @@ public void PropertiesAreSet(string target)
() => buildOutput.GetConsoleLog());
}

[Fact]
public void PublishRespectsNoBuild()
{
string[] projects = new[]
{
ProjectCreator.Create(path: GetTempFileWithExtension(".proj"))
.Target("Build")
.TaskMessage("02CA9347E8BB4C5E856BC0903780CC9B", MessageImportance.High)
.Target("Publish")
.TaskMessage("20B044FEEC3E435D90CE721012C6577E", MessageImportance.High)
.Save(),
}.Select(i => i.FullPath).ToArray();

ProjectCreator
.Templates
.TraversalProject(
projects,
projectCollection: new ProjectCollection(new Dictionary<string, string>
{
["NoBuild"] = "true"
}),
path: GetTempFile("dirs.proj"))
.Save()
.TryBuild("Publish", out bool result, out BuildOutput buildOutput);

result.ShouldBeTrue(customMessage: () => buildOutput.GetConsoleLog());

buildOutput.Messages.ShouldContain("20B044FEEC3E435D90CE721012C6577E", customMessage: () => buildOutput.GetConsoleLog());
buildOutput.Messages.ShouldNotContain("02CA9347E8BB4C5E856BC0903780CC9B", customMessage: () => buildOutput.GetConsoleLog());
}

[Fact]
public void SkipsNonExistentTargets()
{
Expand All @@ -125,6 +156,30 @@ public void SkipsNonExistentTargets()
result.ShouldBeTrue(customMessage: () => buildOutput.GetConsoleLog());
}

[Theory]
[InlineData("Build")]
[InlineData("Clean")]
[InlineData("Pack")]
[InlineData("Publish")]
[InlineData("Test")]
[InlineData("VSTest")]
public void StaticGraphProjectReferenceTargetsAreSetForEachTraversalTarget(string target)
{
ProjectCreator
.Templates
.TraversalProject(
null,
GetTempFile("dirs.proj"))
.Save().TryGetItems("ProjectReferenceTargets", "Targets", out var items);

items.Keys.ShouldContain(target);

items[target].ShouldBe(
target == "Build"
? ".default"
: target);
}

[Theory]
[InlineData("Build")]
[InlineData("Clean")]
Expand Down Expand Up @@ -162,6 +217,31 @@ public void TraversalTargetsRun(string target)
customMessage: () => buildOutput.GetConsoleLog());
}

[Theory]
[InlineData("Build")]
[InlineData("Clean")]
[InlineData("Pack")]
[InlineData("Publish")]
[InlineData("Test")]
[InlineData("VSTest")]
public void TraversalTargetsShouldBeConditionedOnIsGraphBuild(string target)
{
var traversalTarget = ProjectCreator
.Templates
.TraversalProject(
null,
GetTempFile("dirs.proj"))
.Save()
.Project.Targets.Values.FirstOrDefault(t => t.Name.Equals(target, StringComparison.OrdinalIgnoreCase));

traversalTarget.ShouldNotBeNull();

traversalTarget.Condition
.Replace(" ", string.Empty)
.Replace('\"', '\'')
.ShouldContain("'$(IsGraphBuild)'!='true'");
}

[Theory]
[InlineData(null)]
[InlineData("Debug")]
Expand Down Expand Up @@ -196,54 +276,5 @@ public void WorksWhenConfigurationSpecified(string configuration)

result.ShouldBeTrue(customMessage: () => buildOutput.GetConsoleLog());
}

[Theory]
[InlineData("Build")]
[InlineData("Clean")]
[InlineData("Pack")]
[InlineData("Publish")]
[InlineData("Test")]
[InlineData("VSTest")]
public void StaticGraphProjectReferenceTargetsAreSetForEachTraversalTarget(string target)
{
ProjectCreator
.Templates
.TraversalProject(
null,
GetTempFile("dirs.proj"))
.Save().TryGetItems("ProjectReferenceTargets", "Targets", out var items);

items.Keys.ShouldContain(target);

items[target].ShouldBe(
target == "Build"
? ".default"
: target);
}

[Theory]
[InlineData("Build")]
[InlineData("Clean")]
[InlineData("Pack")]
[InlineData("Publish")]
[InlineData("Test")]
[InlineData("VSTest")]
public void TraversalTargetsShouldBeConditionedOnIsGraphBuild(string target)
{
var traversalTarget = ProjectCreator
.Templates
.TraversalProject(
null,
GetTempFile("dirs.proj"))
.Save()
.Project.Targets.Values.FirstOrDefault(t => t.Name.Equals(target, StringComparison.OrdinalIgnoreCase));

traversalTarget.ShouldNotBeNull();

traversalTarget.Condition
.Replace(" ", string.Empty)
.Replace('\"', '\'')
.ShouldContain("'$(IsGraphBuild)'!='true'");
}
}
}
5 changes: 4 additions & 1 deletion src/Traversal/Sdk/Sdk.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,12 @@
ResolveReferences;
</PackDependsOn>

<PublishDependsOn>
<PublishDependsOn Condition="'$(NoBuild)' != 'true'">
Build;
</PublishDependsOn>

<PublishDependsOn Condition="'$(NoBuild)' == 'true'">
</PublishDependsOn>
</PropertyGroup>

<ItemGroup Condition=" '$(TraversalTranslateProjectFileItems)' != 'false' ">
Expand Down