Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect and bubble up "Build" TargetOutputs #183

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Collect and bubble up "Build" TargetOutputs #183

merged 2 commits into from
Jun 2, 2020

Conversation

MeikTranel
Copy link
Contributor

Resolves #181

@MeikTranel
Copy link
Contributor Author

image

This is how it looks when calling a traversal project now. I couldn't bear seeing another level of collectedbuildoutput as the variable name 😄

@MeikTranel
Copy link
Contributor Author

Don't know if this is intended but the testing stage of the AzDO pipeline doesn't seem to run any tests.

@jeffkl
Copy link
Contributor

jeffkl commented Jun 1, 2020

Thanks @MeikTranel, I've fixed the unit test execution. Do you want to rebase and push or should I update your branch in the UI here?

@MeikTranel
Copy link
Contributor Author

Should be good now.

Copy link
Contributor

@jeffkl jeffkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@jeffkl jeffkl merged commit 9dca0b7 into microsoft:master Jun 2, 2020
@MeikTranel MeikTranel deleted the traversalBuildOutputs branch June 2, 2020 18:12
@MeikTranel
Copy link
Contributor Author

No Problem. Is it possible to get this released to nuget so i can use it? Working on something right now where this would be real handy 🤣

@jeffkl
Copy link
Contributor

jeffkl commented Jun 2, 2020

Yeah sorry was working on some signing issues. A new version is on its way to NuGet.

https://www.nuget.org/packages/Microsoft.Build.Traversal

@MeikTranel
Copy link
Contributor Author

Haha absolutely no problemo

@ViktorHofer
Copy link
Member

@MeikTranel great contributions, thanks! Unfortunately this doesn't work for multi-targeting projects: dotnet/msbuild#2148.

@MeikTranel
Copy link
Contributor Author

MeikTranel commented Jul 5, 2020

Yeah i was aware of this when i did this PR. One can work around it, but ultimately the dotnet sdk should do this.

Its not really an issue with the traversal sdk because we have no concept of TFM resolution for projectreference and thus depend upon the dependency being as autonomous as possible.
One day the publish scenario should be looked at, but thats alot of work.

Also: I think if you attach a TFM via AdditionalProperties to the Reference you get the regular Outputs back, because it doesnt override the build task, because its considered InnerLoop already when it enters the Multi-TFM-Project build target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TraversalSDK: Collect TargetOutputs of ProjectReference
3 participants