-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect and bubble up "Build" TargetOutputs #183
Conversation
Don't know if this is intended but the testing stage of the AzDO pipeline doesn't seem to run any tests. |
Thanks @MeikTranel, I've fixed the unit test execution. Do you want to rebase and push or should I update your branch in the UI here? |
Should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
No Problem. Is it possible to get this released to nuget so i can use it? Working on something right now where this would be real handy 🤣 |
Yeah sorry was working on some signing issues. A new version is on its way to NuGet. |
Haha absolutely no problemo |
@MeikTranel great contributions, thanks! Unfortunately this doesn't work for multi-targeting projects: dotnet/msbuild#2148. |
Yeah i was aware of this when i did this PR. One can work around it, but ultimately the dotnet sdk should do this. Its not really an issue with the traversal sdk because we have no concept of TFM resolution for projectreference and thus depend upon the dependency being as autonomous as possible. Also: I think if you attach a TFM via AdditionalProperties to the Reference you get the regular Outputs back, because it doesnt override the build task, because its considered InnerLoop already when it enters the Multi-TFM-Project build target. |
Resolves #181