Merge pull request #3855 from pkernevez/fix-scsecurityfilter-region-s…

…hould-be-empty Region could be empty
microsoft · Nov 1, 2023 · 16a26ee · 16a26ee
2 parents 8577551 + d46a3da
commit 16a26ee
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,9 @@
 * AADRoleEligibilityScheduleRequest
   * Fixes how the Get method retrieves existing instances for Groups.
     FIXES [#3787](https://github.com/microsoft/Microsoft365DSC/issues/3787)
+* SCSecurityFilter
+  * Fixes an issue because Region could be empty
+  FIXES: [#3854](https://github.com/microsoft/Microsoft365DSC/issues/3854)
 * SPOSharingSettings
   * Fixes parameter validation of ExternalUserExpireInDays and ExternalUserExpirationRequired.
     FIXES [#3856](https://github.com/microsoft/Microsoft365DSC/issues/3856)

diff --git a/Modules/Microsoft365DSC/DSCResources/MSFT_SCSecurityFilter/MSFT_SCSecurityFilter.psm1 b/Modules/Microsoft365DSC/DSCResources/MSFT_SCSecurityFilter/MSFT_SCSecurityFilter.psm1
@@ -37,13 +37,13 @@ function Get-TargetResource
             'IND', # India
             'JPN', # Japan
             'LAM', # Latin America
-            'NAM' # North America
+            'NAM', # North America
+            '' # NOT MANDATORY
         )]
         [System.String]
         $Region,
 
         # And the DSC ones
-
         [Parameter()]
         [ValidateSet('Present', 'Absent')]
         [System.String]
@@ -227,7 +227,8 @@ function Set-TargetResource
             'IND', # India
             'JPN', # Japan
             'LAM', # Latin America
-            'NAM' # North America
+            'NAM', # North America
+            '' # NOT MANDATORY
         )]
         [System.String]
         $Region,
@@ -393,7 +394,8 @@ function Test-TargetResource
             'IND', # India
             'JPN', # Japan
             'LAM', # Latin America
-            'NAM' # North America
+            'NAM', # North America
+            '' # NOT MANDATORY
         )]
         [System.String]
         $Region,