MSFT_AADServicePrincipal: Sends "ApplicationSecret" parameter

[jamacneil]

Details of the scenario you tried and the problem that is occurring

When using AADServicePrincipal resource to create/update service principal the "ApplicationSecret" parameter is not removed from $CurrentParameters.

Verbose logs showing the problem

A parameter cannot be found that matches parameter name 'ApplicationSecret'.                                                
+ CategoryInfo             : InvalidArgument: (:) [], CimException                                                         
+ FullyQualifiedErrorId : NamedParameterNotFound,Update-MgServicePrincipal                                              
 PSComputerName       : localhost  

Suggested solution to the issue

In my testing removing 'ApplicationSecret' from $CurrentParameters has resolved this issue.

$currentAADServicePrincipal = Get-TargetResource @PSBoundParameters
$currentParameters = $PSBoundParameters
$currentParameters.Remove('ApplicationId') | Out-Null
$currentParameters.Remove('ApplicationSecret') | Out-Null
$currentParameters.Remove('TenantId') | Out-Null

The DSC configuration that is used to reproduce the issue (as detailed as possible)

AADServicePrincipal "ServicePrincipalName" {
                AppId             = $Application.AppId
                AccountEnabled    = $false
                Ensure            = "Present"
                TenantId          = $TenantId
                ApplicationId     = $ApplicationId
                ApplicationSecret = $ApplicationSecret
            }

The operating system the target node is running

OsName               : Microsoft Windows 11 Enterprise
OsOperatingSystemSKU : EnterpriseEdition
OsArchitecture       : 64-bit
WindowsVersion       : 2009
WindowsBuildLabEx    : 22000.1.amd64fre.co_release.210604-1628
OsLanguage           : en-US
OsMuiLanguages       : {en-US}

Version of the DSC module that was used ('dev' if using current dev branch)

Version: 1.22.1130.1