Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various authentication improvements #2005

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Various authentication improvements #2005

merged 2 commits into from
Jun 14, 2022

Conversation

ykuijs
Copy link
Member

@ykuijs ykuijs commented Jun 10, 2022

Pull Request (PR) description

This PR adds many updates to the module:

  • New cmdlet (Update-M365DSCAzureAdApplication) to create and manage a custom service principal which can be used within Microsoft365DSC configurations
  • Extended the permissions in the settings.json file to include delegated, application and Exchange permissions
  • Updated the Get-M365DSCCompiledPermissionList cmdlet to include the new permissions in the settings.json file
  • Added new cmdlet to generate the resource documentation pages on the microsoft365dsc.com website based on the Readme.md file, settings.json file and examples.
  • Checked and updated the readme.md files of all resources to make them consistent and usable by the new documentation cmdlet
  • Updated the documentation on microsoft365dsc.com to include all updates
  • Corrected documentation issues on the microsoft365dsc.com website

This Pull Request (PR) fixes the following issues

@ykuijs
Copy link
Member Author

ykuijs commented Jun 10, 2022

First attempt for a PR, to see if the Unit tests work or not. @NikCharlebois, maybe you can do a first review as well......the number of changed files is quite large.....sorry 😉

@NikCharlebois NikCharlebois merged commit 0b430e5 into microsoft:Dev Jun 14, 2022
@KuotingChiu
Copy link

Two issues here with the latest DSC module. (1) the Warnings not consistent - it seems two components for Power Platform - PPTenantIsolationSettings and PPTenantSettings do not work with thumbprint authentication but when running Export-M365DSCConfiguration with the -workload parament, only PPTenantIsolationSettings is shown (see the script execution below) (2) the authentication method table shows "Certificate Thumbprint" has a green check box for Power Platform that should be a red cross box instead

----- script result below with certificate thumbprint authentication method -------

PS C:\WINDOWS\system32> Export-M365DSCConfiguration -Path $Path -FileName $FileName -ApplicationId $ApplicationId -CertificateThumbprint $CertificateThumbprint -TenantId $TenantId -Workload "PP"
[WARNING] Based on the provided Authentication parameters, the following resources cannot be extracted:
PPTenantIsolationSettings
⌛ Export took {15 seconds}
PS C:\WINDOWS\system32>
PS C:\WINDOWS\system32> $DscResources = Get-M365DSCAllResources | ?{$_ -like "PP*"}
PS C:\WINDOWS\system32> foreach($resource in $DscResources)

{
$FileName = "$resource.ps1"
Export-M365DSCConfiguration -Path $Path -FileName $FileName -Components $resource -ApplicationId $ApplicationId -CertificateThumbprint $CertificateThumbprint -TenantId $TenantId
}

[1/1] Extracting [PPPowerAppsEnvironment]...✅
⌛ Export took {34 seconds}
[WARNING] Based on the provided Authentication parameters, the following resources cannot be extracted:
PPTenantIsolationSettings
⌛ Export took {11 seconds}
[WARNING] Based on the provided Authentication parameters, the following resources cannot be extracted:
PPTenantSettings
⌛ Export took {10 seconds}

PS C:\WINDOWS\system32> $DscResources
PPPowerAppsEnvironment
PPTenantIsolationSettings
PPTenantSettings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants