Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Get-M365DSCTenantDomain tests for incorrect property #2361 #2362

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Conversation

mlhickey
Copy link
Contributor

@mlhickey mlhickey commented Oct 2, 2022

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

mhickey and others added 2 commits October 2, 2022 11:43
@andikrueger
Copy link
Collaborator

Could you please add this change to the changelog.

Please update your PR description above with

@mlhickey mlhickey changed the title Fixes #2361 Fixes Get-M365DSCTenantDomain tests for incorrect property #2361 Oct 3, 2022
@mlhickey
Copy link
Contributor Author

mlhickey commented Oct 3, 2022

Title changed. General q - should PRs include changelog text as part of the PR? Different for other projects, happy to snap to proper practices here.

@andikrueger
Copy link
Collaborator

It would be great to include the change within the changelog under an Unreleased section. This makes it easier to keep track of all changes within a release.

@mlhickey
Copy link
Contributor Author

mlhickey commented Oct 3, 2022

as long as there's a pattern 😉 will do going forward

@NikCharlebois NikCharlebois merged commit 29d82cf into microsoft:Dev Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants