Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Fixes #293

Merged
merged 5 commits into from
Dec 8, 2019
Merged

Various Fixes #293

merged 5 commits into from
Dec 8, 2019

Conversation

NikCharlebois
Copy link
Collaborator

@NikCharlebois NikCharlebois commented Dec 6, 2019

Pull Request (PR) description

Fixes

This Pull Request (PR) fixes the following issues


This change is Reviewable

@NikCharlebois
Copy link
Collaborator Author

@ykuijs for your review #1

@NikCharlebois NikCharlebois self-assigned this Dec 6, 2019
@NikCharlebois NikCharlebois added the Bug Something isn't working label Dec 6, 2019
@codecov-io
Copy link

codecov-io commented Dec 6, 2019

Codecov Report

Merging #293 into Dev will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##              Dev     #293   +/-   ##
=======================================
  Coverage   90.08%   90.08%           
=======================================
  Files          69       69           
  Lines        7120     7120           
  Branches       10       10           
=======================================
  Hits         6414     6414           
  Misses        696      696           
  Partials       10       10
Impacted Files Coverage Δ
...SC/DSCResources/MSFT_TeamsUser/MSFT_TeamsUser.psm1 55.92% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1af7f0...7ef14c3. Read the comment docs.

Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this single change fix four issues??

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@NikCharlebois
Copy link
Collaborator Author

No, others have been fixed in previous PRs. My bad. It simply fixes #290

@ykuijs
Copy link
Member

ykuijs commented Dec 6, 2019

No update to the changelog?

@NikCharlebois
Copy link
Collaborator Author

Good catch. Changelog updated

Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @NikCharlebois)

@NikCharlebois NikCharlebois merged commit 9312296 into microsoft:Dev Dec 8, 2019
@NikCharlebois NikCharlebois deleted the Fixes branch December 8, 2019 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TeamsUser User property is not correctly extracted
3 participants