-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various Fixes #293
Various Fixes #293
Conversation
Codecov Report
@@ Coverage Diff @@
## Dev #293 +/- ##
=======================================
Coverage 90.08% 90.08%
=======================================
Files 69 69
Lines 7120 7120
Branches 10 10
=======================================
Hits 6414 6414
Misses 696 696
Partials 10 10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this single change fix four issues??
Reviewed 1 of 1 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
No, others have been fixed in previous PRs. My bad. It simply fixes #290 |
No update to the changelog? |
Good catch. Changelog updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @NikCharlebois)
Pull Request (PR) description
Fixes
This Pull Request (PR) fixes the following issues
This change is