Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AADAdministrativeUnit ScopedRoleMembers of Group or ServicePrincipal type - fixes #3189 #3190

Merged
merged 4 commits into from
Apr 20, 2023
Merged

Fix AADAdministrativeUnit ScopedRoleMembers of Group or ServicePrincipal type - fixes #3189 #3190

merged 4 commits into from
Apr 20, 2023

Conversation

Borgquite
Copy link
Contributor

@Borgquite Borgquite commented Apr 19, 2023 •
edited
Loading

Pull Request (PR) description

Fix AADAdministrativeUnit ScopedRoleMembers of Group or ServicePrincipal type

This Pull Request (PR) fixes the following issues

ykuijs
ykuijs requested changes Apr 19, 2023
View reviewed changes
Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update with Dev? And since we just released a new version, create a new Unreleased header?

@Borgquite
Copy link
Contributor Author

Done!

ykuijs
ykuijs approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykuijs ykuijs merged commit c3d44d3 into microsoft:Dev Apr 20, 2023
@Borgquite Borgquite deleted the patch-2 branch April 21, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykuijs ykuijs ykuijs approved these changes

@NikCharlebois NikCharlebois Awaiting requested review from NikCharlebois NikCharlebois is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AADAdministrativeUnit: Cannot set ScopedRoleMembers with RoleMemberInfo Type of Group (or ServicePrincipal)
2 participants
@Borgquite @ykuijs