Fix/#3885 aad conditional access policy #3916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andikrueger
reviewed
Nov 22, 2023
CHANGELOG.md
Outdated
| @@ -8,6 +8,8 @@ | |||
| * AADServicePrincipal | |||
| * Added support to define members. | |||
| FIXES [#3902](https://github.com/microsoft/Microsoft365DSC/issues/3902) | |||
| * AADConditionalAccessPolicy | |||
There was a problem hiding this comment.
Could you move this part to the unreleased section? Thanks
andikrueger
reviewed
Nov 22, 2023
...soft365DSC/DSCResources/MSFT_AADConditionalAccessPolicy/MSFT_AADConditionalAccessPolicy.psm1
Outdated
Show resolved
Hide resolved
|
This PR needs an update from Dev before we can merge. And what about other properties, like IncludedApplication? Shouldn't the same change be implemented for that property as well?? |
sandrola
force-pushed
the
fix/#3885-AADConditionalAccessPolicy
branch
from
a48fc4f
to
cb586e8
Compare
|
By Sync Fork my Branch I woud have to discard the commit, and so also the Pull request. I have created a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
FIXES #3885 AADConditionalAccesspolicy ExcludedApplication are not deleted if empty
This Pull Request (PR) fixes the following issues