-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resources: EXOReportSubmissionPolicy and EXOReportSubmissionRule #4110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I do have a few comments
Modules/Microsoft365DSC/DSCResources/MSFT_EXOReportSubmissionPolicy/readme.md
Outdated
Show resolved
Hide resolved
...oft365DSC/Examples/Resources/EXOReportSubmissionPolicy/1-ConfigureReportSubmissionPolicy.ps1
Outdated
Show resolved
Hide resolved
Tests/Unit/Microsoft365DSC/Microsoft365DSC.EXOReportSubmissionPolicy.Tests.ps1
Outdated
Show resolved
Hide resolved
Tests/Unit/Microsoft365DSC/Microsoft365DSC.EXOReportSubmissionPolicy.Tests.ps1
Show resolved
Hide resolved
Tests/Unit/Microsoft365DSC/Microsoft365DSC.EXOReportSubmissionPolicy.Tests.ps1
Show resolved
Hide resolved
...365DSC/DSCResources/MSFT_EXOReportSubmissionPolicy/MSFT_EXOReportSubmissionPolicy.schema.mof
Outdated
Show resolved
Hide resolved
...rosoft365DSC/DSCResources/MSFT_EXOReportSubmissionPolicy/MSFT_EXOReportSubmissionPolicy.psm1
Outdated
Show resolved
Hide resolved
...rosoft365DSC/DSCResources/MSFT_EXOReportSubmissionPolicy/MSFT_EXOReportSubmissionPolicy.psm1
Outdated
Show resolved
Hide resolved
...rosoft365DSC/DSCResources/MSFT_EXOReportSubmissionPolicy/MSFT_EXOReportSubmissionPolicy.psm1
Outdated
Show resolved
Hide resolved
I added another resource for ReportSubmissionRule to this PR. Both resources belong together. |
Are you sure there can be multiple Policies? This article says "The Identity parameter specifies the report submission policy that you want to modify. The only available policy is named DefaultReportSubmissionPolicy." |
There can be only one policy and one rule. The name of the policy is hardcoded, but the name of the rule can be defined by the admin. |
Ok, got it. Just stumbled on the same info: https://learn.microsoft.com/en-us/microsoft-365/security/office-365-security/submissions-user-reported-messages-custom-mailbox?view=o365-worldwide#use-exchange-online-powershell-to-configure-the-reported-message-settings 😉 And once you created a rule with a different name, you cannot rename it without deleting and recreating it again. Will review the rest of the PR with this in mind! |
You can also rename a already existing rule without recreating. Just tested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more small comments
...365DSC/DSCResources/MSFT_EXOReportSubmissionPolicy/MSFT_EXOReportSubmissionPolicy.schema.mof
Outdated
Show resolved
Hide resolved
.../Microsoft365DSC/DSCResources/MSFT_EXOReportSubmissionRule/MSFT_EXOReportSubmissionRule.psm1
Show resolved
Hide resolved
.../Microsoft365DSC/DSCResources/MSFT_EXOReportSubmissionRule/MSFT_EXOReportSubmissionRule.psm1
Show resolved
Hide resolved
...soft365DSC/DSCResources/MSFT_EXOReportSubmissionRule/MSFT_EXOReportSubmissionRule.schema.mof
Show resolved
Hide resolved
Tests/Unit/Microsoft365DSC/Microsoft365DSC.EXOReportSubmissionPolicy.Tests.ps1
Show resolved
Hide resolved
Tests/Unit/Microsoft365DSC/Microsoft365DSC.EXOReportSubmissionRule.Tests.ps1
Show resolved
Hide resolved
Perfect, then I read the documentation incorrectly.....not an Exchange engineer myself 😛 Please the comments on this in my review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request (PR) description
New resource: EXOReportSubmissionPolicy
This Pull Request (PR) fixes the following issues