Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resources: EXOReportSubmissionPolicy and EXOReportSubmissionRule #4110

Merged
merged 13 commits into from
Jan 3, 2024

Conversation

malauter
Copy link
Member

@malauter malauter commented Jan 2, 2024

Pull Request (PR) description

New resource: EXOReportSubmissionPolicy

This Pull Request (PR) fixes the following issues

Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I do have a few comments

@malauter malauter requested a review from ykuijs January 3, 2024 11:37
@malauter
Copy link
Member Author

malauter commented Jan 3, 2024

I added another resource for ReportSubmissionRule to this PR. Both resources belong together.
There can be only one ReportSubmissionRule, but different from the ReportPermissionPolicy, the name can be chosen.

@malauter malauter changed the title New resource: EXOReportSubmissionPolicy New resources: EXOReportSubmissionPolicy and EXOReportSubmissionRule Jan 3, 2024
@ykuijs
Copy link
Member

ykuijs commented Jan 3, 2024

Are you sure there can be multiple Policies? This article says "The Identity parameter specifies the report submission policy that you want to modify. The only available policy is named DefaultReportSubmissionPolicy."

@malauter
Copy link
Member Author

malauter commented Jan 3, 2024

Are you sure there can be multiple Policies? This article says "The Identity parameter specifies the report submission policy that you want to modify. The only available policy is named DefaultReportSubmissionPolicy."

There can be only one policy and one rule. The name of the policy is hardcoded, but the name of the rule can be defined by the admin.

@ykuijs
Copy link
Member

ykuijs commented Jan 3, 2024

Ok, got it. Just stumbled on the same info: https://learn.microsoft.com/en-us/microsoft-365/security/office-365-security/submissions-user-reported-messages-custom-mailbox?view=o365-worldwide#use-exchange-online-powershell-to-configure-the-reported-message-settings 😉

And once you created a rule with a different name, you cannot rename it without deleting and recreating it again. Will review the rest of the PR with this in mind!

@malauter
Copy link
Member Author

malauter commented Jan 3, 2024

Ok, got it. Just stumbled on the same info: https://learn.microsoft.com/en-us/microsoft-365/security/office-365-security/submissions-user-reported-messages-custom-mailbox?view=o365-worldwide#use-exchange-online-powershell-to-configure-the-reported-message-settings 😉

And once you created a rule with a different name, you cannot rename it without deleting and recreating it again. Will review the rest of the PR with this in mind!

You can also rename a already existing rule without recreating. Just tested.

Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more small comments

@ykuijs
Copy link
Member

ykuijs commented Jan 3, 2024

Ok, got it. Just stumbled on the same info: https://learn.microsoft.com/en-us/microsoft-365/security/office-365-security/submissions-user-reported-messages-custom-mailbox?view=o365-worldwide#use-exchange-online-powershell-to-configure-the-reported-message-settings 😉
And once you created a rule with a different name, you cannot rename it without deleting and recreating it again. Will review the rest of the PR with this in mind!

You can also rename a already existing rule without recreating. Just tested.

Perfect, then I read the documentation incorrectly.....not an Exchange engineer myself 😛 Please the comments on this in my review.

@malauter malauter requested a review from ykuijs January 3, 2024 13:46
Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykuijs ykuijs merged commit 8af1e47 into microsoft:Dev Jan 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Submissions Portal policy and Rule
2 participants