M365DSCUtil: Fix #4333

[ricmestre]

Pull Request (PR) description

If a resource has Name as key then it should be exported to the blueprint with it in its ResourceInstanceName title instead of appearing with Id, this is already done when the key is DisplayName but for Name is not working due to having the condition after Id.

EDIT: Just checked and there are several resources which have Name as Key or Required, hopefully this won't break any setup since Keys are supposed to be unique so having the ResourceInstanceName with the Id or Name should not conflict with other resources of the same type regardless of the key being used.

This Pull Request (PR) fixes the following issues

• Fixes IntuneSettingCatalogCustomPolicyWindows10: Export gets ResourceInstanceName with the Id instead of Name #4333

[andikrueger]

Please have a look at my comment. I haven't run a test but am guessing there might be challenges with other resources.

[ricmestre]

@andikrueger I had a little bit of time to look into it again, could you please check?

I'm calling Get-DscResource on the whole module to cache the information, so it will take longer to export the first resource but then all others will use the cached info otherwise it'd take longer to call Get-DscResource everytime per each resource.

Then I added as heuristics the usual mandatory keys plus Title since I think can be unique amongst other mandatory keys, all others if there are many will be joined together or if it's a single key then it will use that one, all remaining code afterwards was kept.

[andikrueger]

Thanks for looking into it and the change. Just some additional ideas and suggestions.

[andikrueger]

Please have a look at L3402

[andikrueger]

LGTM

[ricmestre]

@andikrueger Forgot about resources that are IsSingleInstance should end up with ResourceInstanceName = ResourceName so I updated the condition to only iterate through the Keys for resources that aren't IsSingleInstance.

[andikrueger]

Thanks for having a second look at it.