-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue #4363 #4373
Fix for issue #4363 #4373
Conversation
@avarga77 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
1 similar comment
@avarga77 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small comments
@@ -69,8 +72,7 @@ function Get-TargetResource | |||
Identity = 'Global' | |||
} | |||
|
|||
try | |||
{ | |||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure you don't update the code styling formatting. This is done in several instances 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the same code file, I see the brackets used in a mixed way. Sometimes
try {
}
and sometimes
try
{
}
I think a single file should at least follow the same format, shouldn't it? My VS Code automatically adjust these. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That indeed should be consistent across all files. Within M365DSC we are using the "open braces on the next line" format, we have VSCode settings included in the project. Your VS Code should automatically use that:
Microsoft365DSC/.vscode/settings.json
Line 22 in 93937c7
"powershell.codeFormatting.openBraceOnSameLine": false, |
It is possible that the wrong format is used. Most probably because we missed that in a past reviews 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will reformat then all the files this way. 😉
@microsoft-github-policy-service agree company="Microsoft" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request (PR) description
TeamsGuestMeetingConfiguration: added the missing parameter AllowTranscription.
This Pull Request (PR) fixes the following issues