AADGroup: Fix issue when filtering groups by display name #4395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Latest release introduced a fix for supporting filtering groups that contained character ' in their displayname, nevertheless this also introduced a bug that now all ' characters were doubled including the ones used in the filter itself.
This fixes that issue by replacing ' with '' only in the DisplayName of the group and not of the filter.
While here also removed showing the current values after Get-TargetResource since I added that on previous release to the Test-TargetResource like it's done across the whole tree.
This Pull Request (PR) fixes the following issues