Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O365 org settings fix parameter defaults to false if not specified #4742

Conversation

afloca
Copy link
Contributor

@afloca afloca commented Jun 7, 2024

Pull Request (PR) description

Check that the Parameters are present in the configuration instead of defaulting to false if not specified

This Pull Request (PR) fixes the following issues

@FabienTschanz
Copy link
Contributor

FabienTschanz commented Jun 7, 2024

Shouldn't a setting go back to its default value if I unset it? Don't know what the corresponding default values for those settings are though. I'm wondering because for the settings catalog in Intune, that works exactly that way. But I'm not familiar with the O365 settings.

@afloca
Copy link
Contributor Author

afloca commented Jun 10, 2024

Shouldn't a setting go back to its default value if I unset it? Don't know what the corresponding default values for those settings are though. I'm wondering because for the settings catalog in Intune, that works exactly that way. But I'm not familiar with the O365 settings.

For most of the settings the default value is enabled, however the expectation is when specifying the desired configuration state on a set of parameters, not specified parameters should not be checked or set to a value (in this case false).
In my case while trying to set the CortanaEnabled Setting, I was getting a 403 Error for the PlannerAllowCalendarSharing that was not specified in the configuration at all - this doesent solve the 403 for Planner, but allows usage of the rest of the settings independently.

…gSettings-fix-parameter-defaults-to-false-if-not-specified
Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykuijs
Copy link
Member

ykuijs commented Aug 23, 2024

@afloca, can you please update your branch with dev? After that we can merge this PR.

…gSettings-fix-parameter-defaults-to-false-if-not-specified
@afloca
Copy link
Contributor Author

afloca commented Aug 26, 2024

@ykuijs Done

Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykuijs ykuijs merged commit 87590f0 into microsoft:Dev Aug 26, 2024
2 checks passed
@afloca afloca deleted the O365OrgSettings-fix-parameter-defaults-to-false-if-not-specified branch August 26, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

O365OrgSettings: Fix: Boolean Parameters default to false if not specified in configuration
3 participants