-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
O365 org settings fix parameter defaults to false if not specified #4742
O365 org settings fix parameter defaults to false if not specified #4742
Conversation
Shouldn't a setting go back to its default value if I unset it? Don't know what the corresponding default values for those settings are though. I'm wondering because for the settings catalog in Intune, that works exactly that way. But I'm not familiar with the O365 settings. |
For most of the settings the default value is enabled, however the expectation is when specifying the desired configuration state on a set of parameters, not specified parameters should not be checked or set to a value (in this case false). |
…gSettings-fix-parameter-defaults-to-false-if-not-specified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@afloca, can you please update your branch with dev? After that we can merge this PR. |
…gSettings-fix-parameter-defaults-to-false-if-not-specified
@ykuijs Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request (PR) description
Check that the Parameters are present in the configuration instead of defaulting to false if not specified
This Pull Request (PR) fixes the following issues