Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[May18] Add UNITY_2017_[3|4]_OR_NEWER in scripts to eliminate deprecated API popups #1921

Closed
david-c-kline opened this issue Apr 6, 2018 · 9 comments
Closed

[May18] Add UNITY_2017_[3|4]_OR_NEWER in scripts to eliminate deprecated API popups #1921

david-c-kline opened this issue Apr 6, 2018 · 9 comments
Assignees
@keveleigh
Labels
Editor

Comments

@david-c-kline
Copy link

Update the MRTK with support for the LTS version of Unity 2017 (2017.4.1f1)
@david-c-kline david-c-kline self-assigned this Apr 6, 2018
@david-c-kline
Copy link
Author

https://unity3d.com/unity/whats-new/unity-2017.4.1

@StephenHodgson
Copy link
Contributor

I don't think Master should move to 2017.4.

It'll break backwards compatibility with 5.6

@StephenHodgson
Copy link
Contributor

If devs want to use 2017.4 they can and unity's auto updater will do everything they need.

@david-c-kline
Copy link
Author

@StephenHodgson, How would it break 5.6 compat? It didn't break when we went to 2017.1 and .2?
Thx!

@StephenHodgson
Copy link
Contributor

Because unity made some Breaking changes to the Editor from 2017.2 -> 2017.3

@StephenHodgson
Copy link
Contributor

The Unity API updater takes care of it for you.

@david-c-kline
Copy link
Author

Potential issue with shader changes needs investigation.... Can we #if UNITY_2017_... in the shader and allow support for pre/post 2017.3 changes?

@StephenHodgson
Copy link
Contributor

Potential issue with shader changes needs investigation.... Can we #if UNITY_2017_... in the shader and allow support for pre/post 2017.3 changes?

No. That's why I've been apprehensive about updating the editor and just letting Unity's auto updater do the work for us.

@david-c-kline david-c-kline changed the title [Master] Update to Unity 2017.4 [May18] Add UNITY_2017_4_OR_NEWER in scripts to eliminate deprecated API popups May 8, 2018
@keveleigh keveleigh assigned keveleigh and unassigned david-c-kline May 8, 2018
@keveleigh keveleigh mentioned this issue May 8, 2018
Merged
@david-c-kline david-c-kline changed the title [May18] Add UNITY_2017_4_OR_NEWER in scripts to eliminate deprecated API popups [May18] Add UNITY_2017_[3|4]_OR_NEWER in scripts to eliminate deprecated API popups May 8, 2018
@david-c-kline david-c-kline mentioned this issue May 8, 2018
Merged
@david-c-kline
Copy link
Author

This was released in the 2017.4.0.0 release candidate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keveleigh keveleigh

Labels
Editor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@keveleigh @david-c-kline @StephenHodgson