Eliminate API conversion popup when loading in Unity 2017.1 #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keveleigh
reviewed
May 8, 2018
| @@ -103,12 +103,20 @@ public override SupportedInputInfo GetSupportedInputInfo(uint sourceId) | |||
|
|
|||
| if (SupportsPosition) | |||
| { | |||
| #if UNITY_2017_1_OR_NEWER | |||
There was a problem hiding this comment.
I think these should just be switched straight up. The source is obsolete for all versions, not just 2017.1 or newer.
| { | ||
| // The input source must provide positional data for this script to be usable | ||
| return; | ||
| } | ||
| #endif | ||
| #endif // UNITY_2017_2_OR_NEWER |
There was a problem hiding this comment.
nope. i fixed it in fb3fc50
There was a problem hiding this comment.
There was a problem hiding this comment.
The PR had been updated
There was a problem hiding this comment.
Also, your red lines don't match up. There's an #endif between them
There was a problem hiding this comment.
Looks good for me now.
| @@ -0,0 +1,10 @@ | |||
| fileFormatVersion: 2 | |||
| guid: 59c43794cfe522246aaa1d4a04cadf68 | |||
There was a problem hiding this comment.
I missed adding this file as part of #2052
|
Do we have a PR for dev branch? |
Organizing usings and fixing 2017.1 build errors in SpectatorView
keveleigh
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add UNITY_2017_1_OR_NEWER blocks (and modify some existing 2017_2 blocks) to eliminate the API conversion popup when loading the MRTK in Unity 2017.1
There isn't an issue for this, it is an extension of #1921.