Fixed issue where Controller Visuals weren't initialized before OnSourceDetected #10625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogPodge
requested review from
david-c-kline,
keveleigh,
julenka,
MenelvagorMilsom and
macborow
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
keveleigh
reviewed
Jun 1, 2022
Assets/MRTK/Providers/Oculus/XRSDK/Controllers/OculusXRSDKTouchController.cs
Show resolved
Hide resolved
Assets/MRTK/Providers/Oculus/XRSDK/Controllers/OculusXRSDKTouchController.cs
Outdated
Show resolved
Hide resolved
…hController.cs Co-authored-by: Kurtis <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
keveleigh
approved these changes
Jun 1, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The Oculus Controller's Visuals property would not be initialized prior to OnSourceDetected getting raised, despite it behaving differently on other platforms. This change realigns the behavior to match other platforms
Changes