TapToPlace needs to let event system know when a click is handled #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andled Fixes issue #1328. If TapToPlace does not call eventData.Use() then fallback handlers will repsond to the tap/click event. This can lead to undersirable behavior while placing an object.
StephenHodgson
approved these changes
Nov 10, 2017
|
@angelaHillier should we advice devs to always call See #1336 |
|
Yes, that would be good guidance. There might be some exceptions for when you don't want the click to be consumed. As a developer, I find it's easier to comment out code like this, then to have to re-add it when I upgrade to a newer version of MRTK. |
|
Oh I agree, this is a good change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1328. If TapToPlace does not call eventData.Use() then fallback handlers will respond to the tap/click event. This can lead to undersirable behavior while placing an object.