Platforms2

[trzy]

Add QueryTopology_FindLargestPositionsSittable() to Unity and update the Spatial Understanding demo with this query. This is the companion to: microsoft/MixedRealityToolkit#86

Note: this should replace Platforms #651.

[StephenHodgson]

nit: extra line?

[trzy]

Extra line should be fixed now.

[NeerajW]

Just to help devs understand, what do you mean by sittable area? Is it like a chair? Couch?

[trzy]

That's a good question :) This is the terminology used by the SpatialUnderstanding library itself and is not something I came up with. My understanding is that these are locations on top of platforms (spanning the entire area of the platform, unlike "platform edge" queries). I've updated the spatial understanding demo as well so you can try out this query and see the kinds of results it returns. I use it my games to place things on tables, couches, beds, etc. (for example, vehicles on the bed and couch in this demo were placed using this query: https://www.youtube.com/watch?v=Ltr9uVWC-5w )

…

On 11/27/2017 6:29 PM, Neeraj Wadhwa wrote: Just to help devs understand, what do you mean by sittable area?

[jessemcculloch]

For clarification, like @trzy mentioned, the term sittable comes from the HoloToolkit/SpatialUnderstanding/Topology queries and is defined as a horizontal plane between the Min and Max heights that conforms to the specified surface area. It could be a chair, it could be a couch, it could be many other things, as long as the surface area of the plane matches, as well as the height falls between the two values.

[jessemcculloch]

Ran unit tests successfully
Deployed to HoloLens and tested functionality successfully

[keveleigh]

Is this change dependent on a new DLL drop?

[StephenHodgson]

That is correct

[jessemcculloch]

Why does it need a new dll drop?
(Not arguing, just not aware of what causes that need)

[keveleigh]

The change on the native side of things, here, added the new method that's imported in this PR. Without it, there should be some sort of import failure.

[jessemcculloch]

That's odd, I tested it with no errors at all

[StephenHodgson]

Only blocking this until we get the binaries updated.

[trzy]

Anything needed from me? Any ETA?

…

Sent from my iPhone

On Jan 5, 2018, at 5:37 PM, Stephen Hodgson ***@***.***> wrote: Only blocking this until we get the binaries updated. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[StephenHodgson]

Nope, you're good. Still waiting on MSFT to sign the binaries.

[keveleigh]

This creates a duplicate button in the Topology menu (the first one is added at line 223). Was in meant to go under Panels.LevelSolver, like the other buttons near it in this list?

[trzy]

I guess I must have mistakenly added that button in two different places -- Panels.Topology and Panels.LevelSolver. It should only exist for Panels.Topology. Please remove the redundant line that is grouped with the LevelSolver panel calls. I would do this myself but I'm frozen back in HoloToolkit-Unity still.

…

On 2/7/2018 5:51 PM, Stephen Hodgson wrote: ***@***.**** commented on this pull request. ------------------------------------------------------------------------ In Assets/HoloToolkit-Examples/SpatialUnderstanding/Scripts/UI.cs <#1435 (comment)>: > @@ -247,6 +248,7 @@ private void SetupMenus() AddButton("OnEdge NearCenter", Panels.LevelSolver, () => { LevelSolver.Instance.Query_OnEdge_NearCenter(); timeLastQuery = DateTime.MinValue; }); AddButton("OnFloor AwayFromMe", Panels.LevelSolver, () => { LevelSolver.Instance.Query_OnFloor_AwayFromMe(); timeLastQuery = DateTime.MinValue; }); AddButton("OnFloor NearMe", Panels.LevelSolver, () => { LevelSolver.Instance.Query_OnFloor_NearMe(); timeLastQuery = DateTime.MinValue; }); + AddButton("Large positions sittable", Panels.Topology, () => { SpaceVisualizer.Instance.Query_Topology_FindLargePositionsSittable(); timeLastQuery = DateTime.MinValue; }); @trzy <https://github.com/trzy> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1435 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABOdxaCdh9F7c_pIHFvc86aYPeZaAkcsks5tSikAgaJpZM4QqS6q>.