Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating and standardizing the license headers #1479

Merged
merged 2 commits into from
Dec 14, 2017

Conversation

keveleigh
Copy link
Contributor

Overview

Updates, adds, and standardizes the license headers across the Toolkit.

@keveleigh keveleigh self-assigned this Dec 5, 2017
@@ -1,6 +1,6 @@
MIT License

Copyright (c) 2016 Microsoft Corporation
Copyright (c) 2017 Microsoft Corporation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add the toolkit version here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yeah, either here or a separate version.txt. It probably makes sense to have it all-in-one.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MRTK_Version.txt or something akin.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added MRTKVersion.txt to the HoloToolkit folder.

Copy link
Contributor

@StephenHodgson StephenHodgson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got some conflicts

@keveleigh
Copy link
Contributor Author

@StephenHodgson Conflicts resolved.

@david-c-kline david-c-kline merged commit 01680ae into microsoft:Dev_Working_Branch Dec 14, 2017
@StephenHodgson
Copy link
Contributor

@keveleigh should we also do this for the stabilization branch?

You might be able to cherry pick that in.

@keveleigh keveleigh deleted the Headers branch December 14, 2017 21:08
@keveleigh
Copy link
Contributor Author

I'd be happy to see it go into the stabilization branch, since it's a "doc" update rather than a feature update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants