Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev→master] Bounding Box and App Bar #1914

Merged

Conversation

cre8ivepark
Copy link
Contributor

@cre8ivepark cre8ivepark commented Apr 5, 2018

mrtk_appbar_boundingbox_examplescene

Overview

Migration to master. Bounding Box & App Bar with an example scene.

Requires

Example scene uses TwoHandManipulatable script. #1849 should be merged first.
Included bug fix for AppBar highlighting #1895

Test scene

Assets/HoloToolkit-Examples/UX/Scenes/BoundingBoxGizmoExample.unity

@StephenHodgson
Copy link
Contributor

Blocked by #1849

@david-c-kline david-c-kline changed the base branch from Patch4_Dev to may18_dev April 5, 2018 16:17
@david-c-kline
Copy link

Adding this to the May 2018 release.

StephenHodgson
StephenHodgson previously approved these changes Apr 5, 2018
@StephenHodgson
Copy link
Contributor

@davidkline-ms if we move this to the May 2018 release, will it won't compile without #1849 also getting merged into this branch

@david-c-kline
Copy link

@StephenHodgson,
I periodically update may18_dev with Patch4_Dev changes. Just did that, in fact with #1917


namespace HoloToolkit.UX.BoundingBoxes
{
public class BoundingBoxGizmoHandle : MonoBehaviour, IInputHandler, ISourceStateHandler

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add documentation (summary blocks, etc) to this file.
Thx!

{
public class BoundingBoxGizmoHandle : MonoBehaviour, IInputHandler, ISourceStateHandler
{
public enum RotationType

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these enums are intended to be public, please move them outside of the class.


using System;
using System.Collections;
using UnityEngine;

namespace HoloToolkit.Unity.UX
namespace HoloToolkit.UX.BoundingBoxes
{
public class Duplicator : MonoBehaviour

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add documentation (summary blocks, etc) to this file.
Thx!

@david-c-kline
Copy link

Moving back to 2017.2.1.4. This change is fairly small and 100% useful

@david-c-kline david-c-kline changed the base branch from may18_dev to Patch4_Dev April 5, 2018 17:56
@cre8ivepark
Copy link
Contributor Author

cre8ivepark commented Apr 6, 2018

  • Added summary blocks to AppBarButton, AppBar, BoundingBox, BoundingBoxGizmoHandle.
  • Created separate enum files for the BoundingBoxGizmoHandle.
    -BoundingBoxGizmoHandleAxisToAffectEnum
    -BoundingBoxGizmoHandleHandMotionTypeEnum
    -BoundingBoxGizmoHandleRotationTypeEnum
    -BoundingBoxGizmoHandleTransformTypeEnum
  • Reverted BoundingBox and Duplicator

@cre8ivepark
Copy link
Contributor Author

cre8ivepark commented Apr 6, 2018

Added/updated README files. Updated landing page links,

BoundingBox and AppBar
TwoHandManipulation
Landing page examples links update

Copy link

@david-c-kline david-c-kline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issues in some of the README files that need to be fixed to avoid broken links.

Could also use a little more doc comments in the source (but I wont block for those)


The scene also demonstrates how to use [Receiver](/Assets/HoloToolkit/UX/Scripts/Receivers/InteractionReceiver.cs) to handle events comging from multiple objects, in a single script. This is especially useful when you have multiple buttons or interactable objects in a scene.
The scene also demonstrates how to use [Receiver](/Assets/MixedRealityToolkit/UX/Scripts/Receivers/InteractionReceiver.cs) to handle events comging from multiple objects, in a single script. This is especially useful when you have multiple buttons or interactable objects in a scene.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Master branch is still using HoloToolkit[-Examples]


## Ways to use Object collection ##
You can find the examples in the scene **ObjectCollection_Examples.unity**. In this scene, you can find the **ObjectCollection.cs** script under **Assets/HoloToolkit/UX/Scripts/Collections**
You can find the examples in the scene **ObjectCollection_Examples.unity**. In this scene, you can find the **ObjectCollection.cs** script under **Assets/MixedRealityToolkit/UX/Scripts/Collections**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Master branch is still using HoloToolkit[-Examples]

david-c-kline
david-c-kline previously approved these changes Apr 9, 2018
@StephenHodgson StephenHodgson merged commit 3241fdb into microsoft:Patch4_Dev Apr 10, 2018
@keveleigh keveleigh deleted the Patch4_Dev_BoundingBoxAppBar branch September 15, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants